emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: emacsclient: support `/' directory separator on w32


From: Eli Zaretskii
Subject: Re: emacsclient: support `/' directory separator on w32
Date: Sat, 25 Nov 2006 12:35:08 +0200

> Date: Sat, 25 Nov 2006 00:15:20 +0000
> From: Jason Rumney <address@hidden>
> Cc: Emacs Devel <address@hidden>
> 
>  if (islower (tolower (filename[0]))
> 
> This looks strange. Is there a good reason not to use isalpha() here?

Are we 110% sure the drive letter can be only something for which
isalpha returns a non-zero value?  What about isalpha in non-English
locales, for example?

Perhaps we should just test that the second character is a colon, and
leave the first one alone?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]