Re: Patch: Syntax and Hard Newlines

[Johan Bockgård]

Richard Stallman <address@hidden> writes:

>     However, unlike `assoc' which returns the matching cons,
>     `assoc-default' returns the cdr. In the code in question it is always
>     nil.
>
> Does this code work right?
>
> *** bytecomp.el       08 Jul 2006 16:59:45 -0400      2.186
> --- bytecomp.el       16 Nov 2006 08:24:45 -0500      
> ***************
> *** 2864,2871 ****
>   
>   (defmacro byte-compile-get-constant (const)
>     `(or (if (stringp ,const)
> !        (assoc-default ,const byte-compile-constants
> !                       'equal-including-properties nil)
>        (assq ,const byte-compile-constants))
>          (car (setq byte-compile-constants
>                 (cons (list ,const) byte-compile-constants)))))
> --- 2864,2875 ----
>   
>   (defmacro byte-compile-get-constant (const)
>     `(or (if (stringp ,const)
> !        ;; In a string constant, treat properties as significant.
> !        (let (result)
> !          (dolist (elt byte-compile-constants)
> !            (if (equal-including-properties (car elt) ,const)
> !                (setq result elt)))
> !          result)
>        (assq ,const byte-compile-constants))
>          (car (setq byte-compile-constants
>                 (cons (list ,const) byte-compile-constants)))))

I think so.

Also, Chong removed the "Prevent byte compiler from causing spurious
string sharing when it optimizes away calls to functions such as
concat" note from FOR-RELEASE, but it doesn't seem like anything was
done about it.

-- 
Johan Bockgård