Re: eval-when-compile vs defconst

[Richard Stallman]

    (defvar ada-block-start-re
      (eval-when-compile
        (concat "\\<\\(" (regexp-opt '("begin" "declare" "else"
                                       "exception" "generic" "loop" "or"
                                       "private" "select" ))
                "\\|\\(\\(limited\\|abstract\\|tagged\\)[ 
\t\n]+\\)*record\\)\\>"))
      "Regexp for keywords starting Ada blocks.")

It would not be worth any extra complexity just to avoid one call to
concat when the file is loaded.  So even if eval-when-compile were not
a no-op here, I'd say take it out.