Re: Code cleanup.

[David Kastrup]

Richard Stallman <address@hidden> writes:

> The right time for code cleanup would be whenever we
> are installing new features.
>
> However, in my opinion, your change does not either increase
> or decrease readability.  It's a tossup.

Uh, setting tem to "", an artificial empty string, in order to have j
incremented once again before breaking out of the finished loop is
readable?

Is this kind of "readable" synonymous to "comprehensible with serious
effort", reminiscent of mathematicians' use of "trivial" as synonymous
with "provable with serious effort"?

If one hits a terminating condition of a loop, one should exit the
loop instead of setting up artificial values to variables that have
the only purpose of causing an exit at a convenient point later in
time.

In other words: while "readability" is certainly a matter of personal
taste, you find me surprised at your taste.

I don't claim that my proposal was perfect, but I would not have
thought it a tossup.

I'll keep my version in my private tree, and will likely sneak it in
after the release.  At least I hope that nobody will find my proposal
actually strictly less readable than the original, and so we'll at
least get one developer (myself) marginally more happy without
offending others.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum