emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: emacs crashed on windows-xp


From: Jason Rumney
Subject: Re: emacs crashed on windows-xp
Date: Fri, 13 Oct 2006 12:01:00 +0100
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.0.4) Gecko/20060516 Thunderbird/1.5.0.4 Mnenhy/0.7.4.666

Chong Yidong wrote:
      case 'c':
!       /* %c and %l are ignored in `frame-title-format'.
!          (In redisplay_internal, the frame title is drawn _before_ the
!          windows are updated, so the stuff which depends on actual
!          window contents (such as %l) may fail to render properly, or
!          even crash emacs.)  */
!       if (mode_line_target == MODE_LINE_TITLE)
!       return "";
...
      case 'l':
        {
!       int startpos, startpos_byte, line, linepos, linepos_byte;
!       int topline, nlines, junk, height;
! ! /* %c and %l are ignored in `frame-title-format'. */
!       if (mode_line_target == MODE_LINE_TITLE)
!         return "";

I think it would be better to return "%c" and "%l", then it will be more obvious to users that those format specifiers are not handled in the title-bar. Returning a blank string makes it look like those specifiers were handled in some way, and may lead to bug reports.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]