emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: Possible bugs in (get last-command...) and (get this-command...)


From: Drew Adams
Subject: RE: Possible bugs in (get last-command...) and (get this-command...)
Date: Wed, 6 Sep 2006 15:16:12 -0700

            But some of the code does not. Perhaps someone
            knowledgeable might want to
            take a look. I noticed, for instance that novice.el and
            ido.el both have
            some unprotected occurrences of (get last-command...) or (get
            this-command...).

        It is safe in novice.el, because that will only get called
        when the command is a symbol and has the property.  I will add
        a comment about that.

        Drew, would you like to find and check all the places which look at
        properties of last-command or this-command, and give us a
        list of the places that might be bugs?

    Sorry, I just don't have the time right now. If I get some
    time, I can try to do that next weekend. If I get to it before then,
    I'll let you know.

I checked the Lisp sources for `get' used with `last-command' and
`this-command'. These are the only occurrences, in a build of 2006-07-19:

ido.el:4476:(eq (get this-command 'ido) 'dir)
ido.el:4482:((and (not (eq (get this-command 'ido) 'ignore))
ido.el:4487:(if (eq (get this-command 'ido) 'find-file) nil 'ignore))
novice.el:65:(if (stringp (get this-command 'disabled))
novice.el:66:(princ (get this-command 'disabled))
cua-base.el:1100:(let ((movement (eq (get this-command 'CUA) 'move)))
cua-base.el:1142:(let* ((ds (or (get this-command 'delete-selection)
cua-base.el:1143:(get this-command 'pending-delete)))
flyspell.el:716:(or (get this-command 'flyspell-delayed)
flyspell.el:717:(and (get this-command
'flyspell-deplacement)flyspell.el:789:     ((get this-command
'flyspell-deplacement)
flyspell.el:791:((get this-command 'flyspell-delayed)
flyspell.el:833:(get this-command 'flyspell-delayed))))
flyspell.el:854:(get this-command 'flyspell-delayed)))
flyspell.el:929:(if (and (symbolp this-command) (get this-command
'flyspell-delayed))

Kim mentioned that he checked ido.el.
RMS mentioned that he checked novice.el.

HTH





reply via email to

[Prev in Thread] Current Thread [Next in Thread]