Re: GTK `read-file-name' dialog

[Reiner Steib]

On Sat, Sep 02 2006, Jan D. wrote:

> I have made some changes.  Please try it and see if you find it better.

The fix for default file name works fine, AFAICS.  Thanks.

But the "or type ..." text still needs improvement, I think.  With
`emacs -Q /tmp/foo.bar':

- `<File> <Visit New File>' I get "type C-x C-w to write files".
  Incorrect, should be `C-x C-f'.

- `<File> <Open File>' => "... type C-x C-f to visit files".  Correct.

- `<File> <Open Directory>' => "... type C-x C-f to visit files".
  Incorrect, should be `C-x d'.

- `<File> <Insert File>' => "... type C-x C-f to visit files".
  Incorrect, should be `C-x i'.  In the console, I get:

,----
| (emacs:32474): Gtk-CRITICAL **: file gtkfilechooserdefault.c: line 4136 
(gtk_file_chooser_default_set_current_name): assertion `impl->action == 
GTK_FILE_CHOOSER_ACTION_SAVE || impl->action == 
GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER' failed
`----

- `<File> <Save As>' => "... type C-x C-w to write files".  Correct.

- In Gnus, when on a MIME button: `<MIME Part> <Save...>'
  (gnus-mime-save-part) => "type C-x C-w to write files".  Misleading:
  `C-x C-w' doesn't save MIME parts.

I think the part ", or type ..." should be removed or generalized
(maybe "or use the corresponding key binding.").  A particular key
binding should only be mentioned if we are sure that it corresponds to
the current action.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/