emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: comint-insert-input on non-command lines: A trivial fix, a quibble,


From: Luc Teirlinck
Subject: Re: comint-insert-input on non-command lines: A trivial fix, a quibble, and a bug
Date: Mon, 8 May 2006 22:59:45 -0500 (CDT)

Nick Roberts wrote:

   Since Miles has provided a patch that fixes the bug you pointed out, there
   is no longer an immediate need to purge comint-prompt-regexp in any case

I do not have the impression that Miles' patch fixes the bug with
comint-use-prompt-regexp that I pointed out.  Such a fix would require
using the variable comint-get-old-input again.

Note that `comint-insert-input' takes away the possibility that
derived modes had to adapt the behavior of `comint-copy-old-input' to
the peculiarities of the particular derived mode through the variable
comint-get-old-input, a possibility actually used in ielm buffers,
external Lisp buffers and Scheme buffers (and maybe by some external
packages).  This also breaks the similarity between RET
(comint-send-input) and C-RET, because RET still uses the variable
comint-get-old-input and thereby still respects mode-specific
implementations.

Was there any reason, other than merely a desire to combine two
somewhat similar commands, to get rid of comint-copy-old-input?
Was anything broken about it?

Sincerely,

Luc.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]