emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: patch: vc.el annotation prev/next "in place"


From: Stefan Monnier
Subject: Re: patch: vc.el annotation prev/next "in place"
Date: Wed, 05 Apr 2006 18:04:52 -0400
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)

> !          (temp-buffer-show-function (lambda (buf)
> !                                       (switch-to-buffer buf)
> !                                       (vc-annotate-display-select))))

Any time you use switch-to-buffer, you have to take into account the fact
that it may signal an error (when running inside a dedicated window).

> !     (vc-call annotate-command file (get-buffer-create temp-buffer-name) rev)
> !     (switch-to-buffer temp-buffer-name)
> !     (delete-other-windows)
> !     (vc-annotate-display-select)
> !     (goto-char (point-min))

Same here, but additionally `delete-other-windows' is clearly wrong
in general.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]