emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Wrong fix?


From: Richard Stallman
Subject: Wrong fix?
Date: Sun, 12 Mar 2006 10:45:42 -0500

    +#if 0 /* x_get_arg removes the visibility parameter as a side effect,
    +         but x_create_frame still needs it.  */
       /* Start up iconic or window? */
       x_wm_set_window_state
         (f, (EQ (x_get_arg (dpyinfo, parms, Qvisibility, 0, 0, 
RES_TYPE_SYMBOL),
                 Qicon)
             ? IconicState
             : NormalState));
    +#endif

That seems like the wrong fix to me.  If the goal is simply
to prevent x_get_arg from clearing out the parameter,
then this goes too far--it also prevents the parameter from being used
for calling x_wm_set_window_state.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]