emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: latexenc and `TeX-master'


From: Arne Jørgensen
Subject: Re: latexenc and `TeX-master'
Date: Tue, 24 Jan 2006 00:04:37 +0100
User-agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux)

David Reitter <address@hidden> writes:

> On 22 Jan 2006, at 17:21, Arne Jørgensen wrote:
>
>> Arne Jørgensen <address@hidden> writes:
>>
>>> But it is probably better to check if the file is a regular and then
>>> also check if it is actually readable.
>>
>> Readability is already checked later in the code. Checking whether the
>> file is a regular file is also better checked at that point.
>
> yes, I agree. The second change (below) should catch all other cases.
>
>
> *** latexenc.el       02 Dec 2005 13:24:11 +0000      1.11
> --- latexenc.el       22 Jan 2006 08:52:12 +0000      
> ***************
> *** 174,180 ****
>                           (find-file-noselect latexenc-main-file t)))
>                     (coding-system-base   ;Disregard the EOL part of
> the CS.
>                      (with-current-buffer latexenc-main-buffer
> !                      (or coding-system-for-write buffer-file-coding- 
> system))))
>                 'undecided))))
>       'undecided))
>
> --- 175,183 ----
>                           (find-file-noselect latexenc-main-file t)))
>                     (coding-system-base   ;Disregard the EOL part of
> the CS.
>                      (with-current-buffer latexenc-main-buffer
> !                      (or coding-system-for-write
> !                      buffer-file-coding-system
> !                      'undecided))))
>                 'undecided))))
>       'undecided))

On a first read I just thought this fix was a reindentation of the
code, but now that I've read it more carefully I think it should be
applied :-)

Kind regards

     /arne
-- 
Arne Jørgensen <http://arnested.dk/>





reply via email to

[Prev in Thread] Current Thread [Next in Thread]