[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: menu-bar: disable items when no frame visible

From: Eli Zaretskii
Subject: Re: menu-bar: disable items when no frame visible
Date: Fri, 16 Dec 2005 15:14:47 +0200

> From: Juri Linkov <address@hidden>
> Cc: address@hidden, address@hidden, address@hidden
> Date: Fri, 16 Dec 2005 14:55:34 +0200
> > If you fixed the code to set menu-updating-frame correctly for all
> > platforms, then why did you need to change menu-bar.el as well?
> It sets menu-updating-frame on platforms where menus can be displayed
> in a separate frame.  The change in menu-bar.el is needed for builds
> like tty and non-toolkit where menu bars are displayed in the same
> frame.

The current code already supports the tty case.  And I thought the
non-toolkit builds were handled by your C-level changes.

FWIW, I don't like using the frame returned by selected-frame because
that could enable the menu items if menu-updating-frame is somehow not
set when it should.  We might be sweeping problems under the carpet

reply via email to

[Prev in Thread] Current Thread [Next in Thread]