Re: customizing `frame-background-mode'

[Richard M. Stallman]

    With other words, why not replace

       :type '(choice (choice-item dark)
                     (choice-item light)
                     (choice-item :tag "default" nil)))

    by

       :type '(choice (const dark)
                     (const light)
                     (const :tag "default" nil)))

I think you are right.  Changing "default" to "automatic"
also seems like an improvement.  So here's what I propose to install.
Anyone see any problem with this patch?



*** faces.el    18 Nov 2005 12:03:25 -0500      1.343
--- faces.el    20 Nov 2005 10:26:25 -0500      
***************
*** 1591,1599 ****
           (set-default var value)
           (mapc 'frame-set-background-mode (frame-list)))
    :initialize 'custom-initialize-changed
!   :type '(choice (choice-item dark)
!                (choice-item light)
!                (choice-item :tag "default" nil)))
  
  (defvar default-frame-background-mode nil
    "Internal variable for the default brightness of the background.
--- 1591,1599 ----
           (set-default var value)
           (mapc 'frame-set-background-mode (frame-list)))
    :initialize 'custom-initialize-changed
!   :type '(choice (const dark)
!                (const light)
!                (const :tag "automatic" nil)))
  
  (defvar default-frame-background-mode nil
    "Internal variable for the default brightness of the background.