Re: Tool-bar buttons unresponsive with tooltips on

[Chong Yidong]

Chong Yidong <address@hidden> writes:

> With `emacs -q' and tool-bar-mode on:
>
>   1. Hover the mouse cursor over (e.g.) the "find file" icon
>   2. Wait for the tool-tip to pops up.
>   3. Click [mouse-1].
>
> Result: the tool-tip is dismissed, but the button isn't clicked.  You
> have to click [mouse-1] a second time to launch find-file.
>
> Expected behavior: the [mouse-1] should not only dismisses the
> tool-tip, but also click the button.

This seems to be related to the remember_mouse_glyph changes made a
few days ago.  Reverting this change removes the problem:

2005-10-12  Kim F. Storm  <address@hidden>

        * xdisp.c (remember_mouse_glyph): New generic version based on
        glyph_rect and remember_mouse_glyph from xterm.c enhanced to
        properly handle all different window areas.

        * dispextern.h (remember_mouse_glyph): Add prototype.

        * xterm.c (glyph_rect, remember_mouse_glyph): Remove X versions.
        (note_mouse_movement, XTmouse_position): Use generic
        remember_mouse_glyph, add last_mouse_glyph arg.

        * w32term.c (note_mouse_movement): Fix last_mouse_glyph check.
        (glyph_rect, remember_mouse_glyph): Remove w32 specific versions.
        (note_mouse_movement, w32_mouse_position): Use generic
        remember_mouse_glyph, add last_mouse_glyph arg.

        * macterm.c (note_mouse_movement): Add call to remember_mouse_glyph.
        (glyph_rect, remember_mouse_glyph): Remove mac specific versions.
        (XTmouse_position): Adapt to use generic remember_mouse_glyph
        instead of pixel_to_glyph_coords.

        * window.c (coordinates_in_window): Fix x position for ON_RIGHT_MARGIN.
        Fix x position for ON_TEXT when left margin width > 0.