[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: emacs & MAXPATHLEN
From: |
Giuseppe Scrivano |
Subject: |
Re: emacs & MAXPATHLEN |
Date: |
Fri, 29 Jul 2005 20:30:15 +0200 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) |
"Richard M. Stallman" <address@hidden> writes:
OK, I will fix that errors and make the getcwd code allocated dynamically.
Giuseppe Scrivano
> You're right that xsmfns.c needs to be fixed too. I overlooked that
> one.
>
>
> +#ifdef _GNU_SOURCE
>
> The purpose of _GNU_SOURCE is to control the behavior of
> system header files. User programs should not test it, only set it.
> We could have config test for the existence of get_current_dir_name.
>
> + buf = malloc(strlen(pwd)+1);
> + if(!buf)
> + fatal ("`malloc' failed in init_buffer\n");
>
> Our convention for whitespace is
>
> + buf = malloc (strlen (pwd)+1);
> + if (!buf)
> + fatal ("`malloc' failed in init_buffer\n");
>
> However, the main thing is that you haven't got rid of the
> arbitrary limit. You allocate the buffer dynamically,
> but you don't make it bigger if the data doesn't fit.
- emacs & MAXPATHLEN, Giuseppe Scrivano, 2005/07/28
- Re: emacs & MAXPATHLEN, Richard M. Stallman, 2005/07/28
- Re: emacs & MAXPATHLEN, Giuseppe Scrivano, 2005/07/28
- Re: emacs & MAXPATHLEN, Alfred M\. Szmidt, 2005/07/29
- Re: emacs & MAXPATHLEN, Richard M. Stallman, 2005/07/29
- Re: emacs & MAXPATHLEN,
Giuseppe Scrivano <=
- Re: emacs & MAXPATHLEN, Giuseppe Scrivano, 2005/07/29
- Re: emacs & MAXPATHLEN, Eli Zaretskii, 2005/07/30
- Re: emacs & MAXPATHLEN, Jan D., 2005/07/30
- Re: emacs & MAXPATHLEN, Alfred M\. Szmidt, 2005/07/30
- Re: emacs & MAXPATHLEN, Eli Zaretskii, 2005/07/30
- Re: emacs & MAXPATHLEN, Alfred M\. Szmidt, 2005/07/30
- Re: emacs & MAXPATHLEN, Andreas Schwab, 2005/07/30
- Re: emacs & MAXPATHLEN, Eli Zaretskii, 2005/07/30
- Re: emacs & MAXPATHLEN, Jan D., 2005/07/30
- Re: emacs & MAXPATHLEN, Andreas Schwab, 2005/07/30