Re: obsolete comment in tool-bar.el

[Luc Teirlinck]

I reinstalled my original changes, deleted the autoload for tooltip
mode and committed my changes to define-minor-mode.  The two last
steps should enable Emacs to be built on Mac OS 9, even with my
changes, although I can not test that.

       Unfortunately, I can not reinstate the use of
       `custom-reevaluate-setting' for tooltip-mode in startup.el.  Unless we
       would be willing to load tooltip.el even on systems where it makes no
       sense, we just have to live with the code duplication here.

   How do you reach this conclusion?  I do not understand.

To allow Emacs to be built on certain operating systems with my
reinstalled changes, I had to remove the autoload for tooltip-mode.
But that means that `custom-reevaluate-settings' in certain situations
(when tooltip is not preloaded, that is, when x-show-tip is not
fboundp) "reevaluates" the defcustom before the defcustom has been
executed.  In the case of tooltip-mode, that actually turns out to be
OK, because if the defcustom has not yet been executed,
`custom-reevaluate-settings' sets the variable to nil, which in the
case of tooltip mode happens to be the correct value in all situations
where tooltip is not preloaded.

So I readded the `custom-reevaluate-settings' for tooltip-mode.  It
kind of works by accident rather than by design however, and may not
work in other similar cases.

       Here is the required patch to easy-mmode.el.  Stefan opposed a similar
       patch earlier, but the objections he then stated (that loading a file
       would have side effects) do not apply to custom-initialize-safe-default.

   It seems ok to me, but the doc string should mention :initialize
   and explain that the only legitimate value to use with it is
   custom-initialize-safe-default, and when that should be used.

I committed the non-doc changes to easy-mmode.el.  Here are the
proposed doc changes which I could install if desired:

===File ~/easy-mmode-diff===================================
*** easy-mmode.el       12 Jul 2005 21:14:49 -0500      1.68
--- easy-mmode.el       13 Jul 2005 20:53:55 -0500      
***************
*** 105,112 ****
    It will be executed after any toggling but before running the hook variable
    `mode-HOOK'.
    Before the actual body code, you can write keyword arguments (alternating
!   keywords and values).  These following keyword arguments are supported 
(other
!   keywords will be passed to `defcustom' if the minor mode is global):
  :group GROUP  Custom group name to use in all generated `defcustom' forms.
                Defaults to MODE without the possible trailing \"-mode\".
                Don't use this default group name unless you have written a
--- 105,111 ----
    It will be executed after any toggling but before running the hook variable
    `mode-HOOK'.
    Before the actual body code, you can write keyword arguments (alternating
!   keywords and values).  The following keyword arguments are supported:
  :group GROUP  Custom group name to use in all generated `defcustom' forms.
                Defaults to MODE without the possible trailing \"-mode\".
                Don't use this default group name unless you have written a
***************
*** 122,128 ****
  For example, you could write
    (define-minor-mode foo-mode \"If enabled, foo on you!\"
      :lighter \" Foo\" :require 'foo :global t :group 'hassle :version \"27.5\"
!     ...BODY CODE...)"
    (declare (debug (&define name stringp
                           [&optional [&not keywordp] sexp
                            &optional [&not keywordp] sexp
--- 121,136 ----
  For example, you could write
    (define-minor-mode foo-mode \"If enabled, foo on you!\"
      :lighter \" Foo\" :require 'foo :global t :group 'hassle :version \"27.5\"
!     ...BODY CODE...)
! 
! If the minor mode is global other keywords are passed to `defcustom'.
! However, the value of the :set keyword is hard coded to
! `custom-set-minor-mode' and the value of the :type keyword is hard coded
! to `boolean'.  The value of the :initialize keyword defaults to
! `custom-initialize-default'.  This default can be overridden using
! an explicit :initialize keyword.  However, the only known situation
! in which such an override is acceptable is for some preloaded global
! minor modes which need to use `custom-initialize-safe-default'."
    (declare (debug (&define name stringp
                           [&optional [&not keywordp] sexp
                            &optional [&not keywordp] sexp
============================================================