Re: Patch to fix error in Emacs-Lisp Reference Manual

[Luc Teirlinck]

 Francis Litterio wrote:

   --- keymaps.texi     10 Aug 2004 11:40:14 -0400      1.53
   +++ keymaps.texi     12 Jan 2005 14:14:34 -0500      
   @@ -566,7 +566,7 @@
    supply a binding for the key, Emacs searches the local map; if that too
    has no binding, Emacs then searches the global map.  However, if
    @code{overriding-local-map} is address@hidden, Emacs searches that map
   -first, before the global map.
   +first, before the minor mode maps.

and Thien-Thi Nguyen wrote:

   thanks, installed.

Sorry, for not noticing this thread before.  This change is wrong.  A
little bit earlier in `(elisp)Active Keymaps' we see:

   The variable `overriding-local-map', if non-`nil', specifies
   another local keymap that overrides the buffer's local map and all
   the minor mode keymaps.

and a little bit later:

 -- Variable: overriding-local-map
     If non-`nil', this variable holds a keymap to use instead of the
     buffer's local keymap, text property or overlay keymaps, and
     instead of all the minor mode keymaps.  This keymap, if any,
     overrides all other maps that would have been active, except for
     the current global map.


In other words, `overriding-local-map' _overrides_ the minor mode
keymaps and the local map.  If it is non-nil, it is called before the
_global_ map, and _not_ before the minor mode maps, which are not
called at all.

The easiest fix would be to just revert the change.  Alternatively,
one could clarify the sentence, as in the patch below, even though it
gets rather repetitive, because exactly the same thing is already
pointed out a little bit earlier and a little bit later.

===File ~/keymaps.texi-diff=================================
*** keymaps.texi        13 Jan 2005 07:53:17 -0600      1.54
--- keymaps.texi        13 Jan 2005 08:33:29 -0600      
***************
*** 566,572 ****
  supply a binding for the key, Emacs searches the local map; if that too
  has no binding, Emacs then searches the global map.  However, if
  @code{overriding-local-map} is address@hidden, Emacs searches that map
! first, before the minor mode maps.
  
  @cindex major mode keymap
    Since every buffer that uses the same major mode normally uses the
--- 566,573 ----
  supply a binding for the key, Emacs searches the local map; if that too
  has no binding, Emacs then searches the global map.  However, if
  @code{overriding-local-map} is address@hidden, Emacs searches that map
! first, before the before the global map and ignores the minor mode
! maps and the local map.
  
  @cindex major mode keymap
    Since every buffer that uses the same major mode normally uses the
============================================================