Re: abort in `make-frame'

[Richard Stallman]

          x-create-frame(((visibility) (icon-left . 0)))
          x-create-frame-with-faces(((icon-left . 0)))
          make-frame(((icon-left . 0)))
          eval((make-frame (quote (...))))
          eval-expression((make-frame (quote (...))) nil)
          call-interactively(eval-expression)

    Now, this is expected.

    What I did not expect is that quitting out of the debugger with `q'
    would make Emacs abort.  Is this unavoidable?

The cause of this is surely that the error is signaled at a time
when the frame is already partly set up.  One needs to debug the
code around that place.  When the actual abort happens, that's too
late to be interesting.

The error is signaled from x_icon, which has not yet done anything
interesting.  But x_icon is called from Fx_create_frame after it
has already created the frame's window.

Does this fix it?

*** xfns.c      14 May 2004 05:26:50 -0400      1.610
--- xfns.c      21 Jul 2004 17:47:42 -0400      
***************
*** 2633,2638 ****
--- 2633,2660 ----
  #endif /* not USE_GTK */
  #endif /* not USE_X_TOOLKIT */
  
+ /* Verify that the icon position args for this window are valid.  */
+ 
+ static void
+ x_icon_verify (f, parms)
+      struct frame *f;
+      Lisp_Object parms;
+ {
+   Lisp_Object icon_x, icon_y;
+ 
+   /* Set the position of the icon.  Note that twm groups all
+      icons in an icon window.  */
+   icon_x = x_frame_get_and_record_arg (f, parms, Qicon_left, 0, 0, 
RES_TYPE_NUMBER);
+   icon_y = x_frame_get_and_record_arg (f, parms, Qicon_top, 0, 0, 
RES_TYPE_NUMBER);
+   if (!EQ (icon_x, Qunbound) && !EQ (icon_y, Qunbound))
+     {
+       CHECK_NUMBER (icon_x);
+       CHECK_NUMBER (icon_y);
+     }
+   else if (!EQ (icon_x, Qunbound) || !EQ (icon_y, Qunbound))
+     error ("Both left and top icon corners of icon must be specified");
+ }
+ 
  /* Handle the icon stuff for this window.  Perhaps later we might
     want an x_set_icon_position which can be called interactively as
     well.  */
***************
*** 3116,3121 ****
--- 3138,3145 ----
  
    tem = x_get_arg (dpyinfo, parms, Qunsplittable, 0, 0, RES_TYPE_BOOLEAN);
    f->no_split = minibuffer_only || EQ (tem, Qt);
+ 
+   x_icon_verify (f, parms);
  
    /* Create the X widget or window.  */
  #ifdef USE_X_TOOLKIT