Re: Please check-in Belanger's Calc patches

[Stefan]

[...]
>       calc-invocation-macro, calc-show-banner): Define these as part of
>           `calc-mode-var-list's initialization, instead of using defvar.

Not defining those vars with defvar means that the byte-compiler doesn't
get the info it wants.  It doesn't necessarily lead to wrong code, but it's
very bad coding style and can prevent optimizations (which are admittedly
not currently implemented).  It also leads to lots and lots of spurious
warnings during byte-compilation.


        Stefan