emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: next-error-last-buffer


From: Juri Linkov
Subject: Re: next-error-last-buffer
Date: Mon, 10 May 2004 02:32:34 +0300
User-agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux)

Richard Stallman <address@hidden> writes:
>     I think that `next-error-last-buffer' should be set buffer-locally
>     in the compilation buffer
>
> Isn't next-error in a compilation buffer already supposed to operate
> on the current buffer?  If so, this change would be a no-op.
> It might be that this is a cleaner way to implement that feature
> than the code that currently implements it.

Yes, setting `next-error-last-buffer' locally in the compilation
buffer is not necessary with the current logic in `next-error-find-buffer',
but it could be set only for consistency.

>                             as well as in every source file visited
>     from that compilation buffer.
>
> That is an interesting idea, but I think it will screw up the
> interaction between compilation and occur, which was the whole point
> of the recent changes.

I tested this change, and it seems to work correctly with occur,
i.e. it allows to continue visiting next occurrences from the same
occur buffer where the current source buffer was visited from,
even if it is not from the last occur/compile/grep.

However, `occur-next-error' has its own problems that should be fixed
(it can't jump to multiple occurrences on the same line, it don't move
the point in the occur buffer like `compilation-goto-locus' does).

-- 
Juri Linkov
http://www.jurta.org/emacs/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]