Re: [PATCH] unexec() for Cygwin port

[Eli Zaretskii]

> From: Joe Buehler <address@hidden>
> Date: Mon, 29 Mar 2004 08:38:26 -0500
> 
> Below is a final set of patches to complete the Cygwin port for 21.3.50
> that I did about a year ago.  These patches add unexec() support for
> Cygwin, which is currently missing in CVS.

Thanks!

> Please commit it to CVS as soon as possible...

I have several minor comments:

> -mallocobj = $(gmallocobj) $(rallocobj) vm-limit.o
> -
>   #endif /* SYSTEM_MALLOC */
> 
> 
> @@ -643,7 +645,11 @@
> 
>   /* define otherobj as list of object files that make-docfile
>      should not be told about.  */
> -otherobj= $(termcapobj) lastfile.o $(mallocobj) $(allocaobj) $(widgetobj) 
> $(LIBOBJS)
> +#ifdef CYGWIN
> +otherobj= $(termcapobj) $(gmallocobj) $(rallocobj) lastfile.o vm-limit.o 
> $(allocaobj) $(widgetobj) $(LIBOBJS)
> +#else
> +otherobj= $(termcapobj) lastfile.o $(gmallocobj) $(rallocobj) vm-limit.o 
> $(allocaobj) $(widgetobj) $(LIBOBJS)
> +#endif

Can you explain the need for this change, and n particular, why is it
important to order *.o files differently for Cygwin?

> +#if defined(CYGWIN)
> +  if (!bss_sbrk_did_unexec) {
> +    return bss_sbrk(increment);
> +  }
> +#endif

Here and elsewhere in your changes, you use code style that is
different from what we use in Emacs and in general in the GNU project:

    if (!bss_sbrk_did_unexec)
      {
        return bss_sbrk(increment);
      } 

Also, the code has lots of printf statements, most of which seem to be
left-overs from testing/debugging phase.  If so, they should be
removed or #ifdef'ed away, I think.

Btw, does unexcw.c handle correctly the debug info in temacs.exe,
i.e., is that info copied into emacs.exe so that Emacs could be
debugged?  (I'm asking because I don't see code that copies and
possibly fixes up the debug info sections.)