[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Emacs 21.3.50 grep.el/executable.el problems
From: |
Ehud Karni |
Subject: |
Emacs 21.3.50 grep.el/executable.el problems |
Date: |
Sat, 14 Feb 2004 17:04:42 +0200 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
I just loaded Emacs 21.3.50 from CVS and built it.
I found the following problems:
1. progmodes/gerp.el calls `executable-command-find-unix-p' instead
of `executable-command-find-posix-p'.
2. progmodes/executable.el calls `find-if' which is defined in
cl-seq.el and requires the cl.el .
Below are my suggested changes.
Ehud.
cd /lnx1/gnu/src/emacs/lisp/progmodes/
diff -c /lnx1/gnu/src/emacs/lisp/progmodes/grep.el.\~1.6.\~
/lnx1/gnu/src/emacs/lisp/progmodes/grep.el
*** /lnx1/gnu/src/emacs/lisp/progmodes/grep.el.~1.6.~ Sat Feb 14 15:02:38 2004
- --- /lnx1/gnu/src/emacs/lisp/progmodes/grep.el Sat Feb 14 15:37:27 2004
***************
*** 318,324 ****
'gnu)))
(unless grep-find-command
(setq grep-find-command
! (cond ((not (executable-command-find-unix-p "find"))
(message
(concat "compile.el: Unix type find(1) not found. "
"Please set `grep-find-command'."))
- --- 318,324 ----
'gnu)))
(unless grep-find-command
(setq grep-find-command
! (cond ((not (executable-command-find-posix-p "find"))
(message
(concat "compile.el: Unix type find(1) not found. "
"Please set `grep-find-command'."))
Diff finished at Sat Feb 14 16:27:32
cd /lnx1/gnu/src/emacs/lisp/progmodes/
diff -c /lnx1/gnu/src/emacs/lisp/progmodes/executable.el.\~1.30.\~
/lnx1/gnu/src/emacs/lisp/progmodes/executable.el
*** /lnx1/gnu/src/emacs/lisp/progmodes/executable.el.~1.30.~ Wed Feb 4
14:33:38 2004
- --- /lnx1/gnu/src/emacs/lisp/progmodes/executable.el Sat Feb 14 16:17:15 2004
***************
*** 146,156 ****
If PROGRAM is non-nil, use that instead of \"find\"."
;; Pick file to search from location we know
(let* ((dir (car load-path))
! (file (find-if
! (lambda (x)
! ;; Filter directories . and ..
! (not (string-match "^\\.\\.?$" x)))
! (directory-files dir))))
(with-temp-buffer
(call-process (or program "find")
nil
- --- 146,158 ----
If PROGRAM is non-nil, use that instead of \"find\"."
;; Pick file to search from location we know
(let* ((dir (car load-path))
! (files (directory-files dir))
! file)
! (while files
! (setq file (car files))
! (if (string-match "^\\.\\.?$" file)
! (setq files (cdr files))
! (setq files nil)))
(with-temp-buffer
(call-process (or program "find")
nil
Diff finished at Sat Feb 14 16:25:28
- --
Ehud Karni Tel: +972-3-7966-561 /"\
Mivtach - Simon Fax: +972-3-7966-667 \ / ASCII Ribbon Campaign
Insurance agencies (USA) voice mail and X Against HTML Mail
http://www.mvs.co.il FAX: 1-815-5509341 / \
GnuPG: 98EA398D <http://www.keyserver.net/> Better Safe Than Sorry
-----BEGIN PGP SIGNATURE-----
Comment: use http://www.keyserver.net/ to get my key (and others)
iD8DBQFALjkJLFvTvpjqOY0RAjIZAJ0QbNkgV7bSrOhVoGva0sKOTt8qWwCZAYMT
3OLE1dHNpFQqh1rXjXeGCpY=
=pOIJ
-----END PGP SIGNATURE-----