Re: suggested feature -- console-mode frame title sets Xterm title

[Miles Bader]

Martin Pool <address@hidden> writes:
> Do you have any comments on the patch?  This is my first patch for
> emacs internals, so please don't trust me. :-)

It's a little hard to evaluate in isolation, but here are a few comments:

> diff -dru emacs-21.3/lisp/cus-start.el emacs-21.3-title/lisp/cus-start.el
> +             (tty-frame-use-title display boolean)
> +             (tty-frame-title-start display string)
> +             (tty-frame-title-end display end)

Why are the latter two variables being added to the customize framework?

They seem like low-level variables that are only exported to lisp for
the terminal lisp files to use, not something that a user would
customize.

> diff -dru emacs-21.3/lisp/term/xterm.el emacs-21.3-title/lisp/term/xterm.el
> +(set-variable 'tty-frame-title-start "\e]2;")
> +(set-variable 'tty-frame-title-end "\007")

Why use `set-variable' instead of `set', or indeed, instead of just `setq'?

> diff -dru emacs-21.3/src/dispextern.h emacs-21.3-title/src/dispextern.h
>  void
> +terminal_set_frame_title (line, len)

term.c is not particularly consistent, but in general the naming
convention used seems to be either `set_terminal_foo' or `set_tty_foo'.

> diff -dru emacs-21.3/src/xdisp.c emacs-21.3-title/src/xdisp.c
> +  DEFVAR_BOOL ("tty-frame-use-title", &tty_frame_use_title,
> +"*Show frame titles in the title or status line of text terminals.\n\

I find the name `tty-frame-use-title' a bit odd; how about something
like `tty-show-frame-titles' (it's the first three words of the
docstring, which must mean something :-)?

-Miles
-- 
A zen-buddhist walked into a pizza shop and
said, "Make me one with everything."