Re: `scroll-all-mode' hard to customize

[Stefan Monnier]

> --- 125,136 ----
>   (defun scroll-all-mode (arg)
>     "Toggle Scroll-All minor mode."
>     (interactive "P")
> !   (setq scroll-all-mode
> !     (if (null arg) (not scroll-all-mode)
> !       (> (prefix-numeric-value arg) 0)))
> !   (if scroll-all-mode
> !       (add-hook 'post-command-hook 'scroll-all-check-to-scroll)
> !     (remove-hook 'post-command-hook 'scroll-all-check-to-scroll)))
>   
>   (provide 'scroll-all)

Better yet, use define-minor-mode.


        Stefan

--- scroll-all.el.~1.10.~       Fri Apr 26 14:03:51 2002
+++ scroll-all.el       Fri Aug  9 00:03:15 2002
@@ -39,26 +39,6 @@
 
 ;;; Code:
 
-(defvar running-xemacs (string-match "XEmacs\\|Lucid" emacs-version))
-
-;;;###autoload
-(defcustom scroll-all-mode nil
-  "Control/track scroll locking.
-
-Setting this variable directly does not take effect;
-use either \\[customize] or the function `scroll-all-mode'."
-  :set (lambda (symbol value) (scroll-all-mode (if value 1 0)))
-  :initialize 'custom-initialize-default
-  :require 'scroll-all
-  :type 'boolean
-  :group 'windows)
-
-(if running-xemacs
-    (add-minor-mode 'scroll-all-mode " *SL*")
-  (or (assq 'scroll-all-mode minor-mode-alist)
-      (setq minor-mode-alist
-           (cons '(scroll-all-mode " *SL*") minor-mode-alist))))
-
 (defun scroll-all-function-all (func arg)
   "Apply function FUNC with argument ARG to all visible windows."
   (let ((num-windows (count-windows))
@@ -122,15 +102,12 @@
  
 
 ;;;###autoload
-(defun scroll-all-mode (arg)
+(define-minor-mode scroll-all-mode " *SL*"
   "Toggle Scroll-All minor mode."
-  (interactive "P")
-  (setq scroll-all-mode (not scroll-all-mode))
-  (cond
-   ((eq scroll-all-mode 't)
-    (add-hook 'post-command-hook 'scroll-all-check-to-scroll))
-   ((eq scroll-all-mode 'nil)
-    (remove-hook 'post-command-hook 'scroll-all-check-to-scroll))))
+  :global t
+  (if scroll-all-mode
+      (add-hook 'post-command-hook 'scroll-all-check-to-scroll)
+    (remove-hook 'post-command-hook 'scroll-all-check-to-scroll)))
 
 (provide 'scroll-all)