Re: [PATCH] allow function values for `enable-local-eval'

[Kim F. Storm]

"Stefan Monnier" <monnier+gnu/address@hidden> writes:

> > "Stefan Monnier" <monnier+gnu/address@hidden> writes:
> > 
> > > >     I'm sure crackers will be happy about it.
> > > >     The argument passed to `c-add-style' allows you to buffer-locally
> > > >     set any variable to any value whatsoever.  Hardly "safe" in my book.
> > > > 
> > > > I didn't realize that.  It will be necessary then to check
> > > > the arguments to c-add-style.  Still, it is better to install
> > > > this checking by default than to make users install it as
> > > > a customization.
> > > 
> > > Huh?  I personally don't see the point of using `c-add-style' in
> > > the local variables section.  My understanding is that one guy did that
> > > and mentioned it here, but I have seen no evidence that anybody
> > > else does.
> > > It seems simpler to just set the corresponding variables one by one
> > > in the local variables section.
> > 
> > This requires that you are allowed to change the files!!!
> 
> My point is just that since it's simpler (and doesn't require confirmation)
> to set the variables one by one it's unlikely that this `c-add-tyle'
> is often used in local variables sections.
> 
> So I see no reason to provide special support for it.
> (contrary to the case of `put', for example).

I fully agree   -- provided there is a more generic hook which can be
used to accept "non-trivial" eval:s

Please note that I was not advocating the solution RMS has added; I
simply said that it would solve my specific problem.  

Now that you have pointed out that c-add-style is unsafe, I think it
really doesn't make sense to try to fix that [there are zillions of
other things that people might do in eval: which we cannot possible
configure before-hand.]


-- 
Kim F. Storm <address@hidden> http://www.cua.dk