Re: extern for variables defined in the same file?

[Gerd Moellmann]

address@hidden (Pavel Janík) writes:

> The variable Qmargin is defined only in this file and is not referenced in
> any other file. Is the proper fix here to simply remove mentioned lines
> beginning with extern? 

Yes.

> Or is there any reason to use extern here?  If we declare the
> variable as local we shadow its global value, but why we use extern
> here? Maybe in the past, this variable was defines elsewhere
> (xfaces.c) and this remained? 

That's probably the reason.

> Is it safe to delete it?

With a probability of 1, I'd say.