[Emacs-commit] emacs/lisp/mh-e mh-letter.el ChangeLog

[Bill Wohler]

CVSROOT:        /cvsroot/emacs
Module name:    emacs
Branch:         
Changes by:     Bill Wohler <address@hidden>    06/04/21 17:49:03

Modified files:
        lisp/mh-e      : mh-letter.el ChangeLog 

Log message:
        (mh-insert-letter): If a message number isn't given, throw an error
        rather than using a potentially incorrect message number (closes SF
        #1473729). In addition, use the cur message if mh-sent-from-msg is
        nil (when sending a message, in contrast to replying). Move conversion
        of int to string into interactive stanza so body can assume variables
        are of proper type.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/emacs/emacs/lisp/mh-e/mh-letter.el.diff?tr1=1.13&tr2=1.14&r1=text&r2=text
http://cvs.savannah.gnu.org/viewcvs/emacs/emacs/lisp/mh-e/ChangeLog.diff?tr1=1.210&tr2=1.211&r1=text&r2=text

Patches:
Index: emacs/lisp/mh-e/ChangeLog
diff -u emacs/lisp/mh-e/ChangeLog:1.210 emacs/lisp/mh-e/ChangeLog:1.211
--- emacs/lisp/mh-e/ChangeLog:1.210     Fri Apr 21 01:32:16 2006
+++ emacs/lisp/mh-e/ChangeLog   Fri Apr 21 17:49:02 2006
@@ -1,3 +1,13 @@
+2006-04-21  Bill Wohler  <address@hidden>
+
+       * mh-letter.el (mh-insert-letter): If a message number isn't
+       given, throw an error rather than using a potentially incorrect
+       message number (closes SF #1473729). In addition, use the cur
+       message if mh-sent-from-msg is nil (when sending a message, in
+       contrast to replying). Move conversion of int to string into
+       interactive stanza so body can assume variables are of proper
+       type.
+
 2006-04-20  Bill Wohler  <address@hidden>
 
        * mh-tool-bar.el (image-load-path): Define to shush compiler.
Index: emacs/lisp/mh-e/mh-letter.el
diff -u emacs/lisp/mh-e/mh-letter.el:1.13 emacs/lisp/mh-e/mh-letter.el:1.14
--- emacs/lisp/mh-e/mh-letter.el:1.13   Fri Apr 21 01:32:16 2006
+++ emacs/lisp/mh-e/mh-letter.el        Fri Apr 21 17:49:00 2006
@@ -393,24 +393,26 @@
 This command leaves the mark before the letter and point after it."
   (interactive
    (let* ((folder
-           (mh-prompt-for-folder "Message from"
-                                 mh-sent-from-folder nil))
+           (mh-prompt-for-folder "Message from" mh-sent-from-folder nil))
           (default
-            (if (and (equal folder mh-sent-from-folder)
-                     (numberp mh-sent-from-msg))
-                mh-sent-from-msg
+            (if (equal folder mh-sent-from-folder)
+                (or mh-sent-from-msg (nth 0 (mh-translate-range folder "cur")))
               (nth 0 (mh-translate-range folder "cur"))))
           (message
            (read-string (concat "Message number"
                                 (or (and default
                                          (format " (default %d): " default))
-                                    ": ")))))
+                                    ": "))
+                        nil nil
+                        (if (numberp default)
+                            (int-to-string default)
+                          default))))
      (list folder message current-prefix-arg)))
+  (if (equal message "")
+      (error "No message number given"))
   (save-restriction
     (narrow-to-region (point) (point))
     (let ((start (point-min)))
-      (if (and (equal message "") (numberp mh-sent-from-msg))
-          (setq message (int-to-string mh-sent-from-msg)))
       (insert-file-contents
        (expand-file-name message (mh-expand-file-name folder)))
       (when (not verbatim)