[Emacs-commit] emacs/lisp/mh-e mh-acros.el ChangeLog

[Bill Wohler]

CVSROOT:        /cvsroot/emacs
Module name:    emacs
Branch:         
Changes by:     Bill Wohler <address@hidden>    06/01/14 02:10:11

Modified files:
        lisp/mh-e      : mh-acros.el ChangeLog 

Log message:
        (require): Added Satyaki's comment regarding what needs to happen to
        remove this defadvice which caused a little discussion on emacs-devel
        today (see Subject: mh-e/mh-acros.el advices `require' incorrectly).

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/emacs/emacs/lisp/mh-e/mh-acros.el.diff?tr1=1.13&tr2=1.14&r1=text&r2=text
http://cvs.savannah.gnu.org/viewcvs/emacs/emacs/lisp/mh-e/ChangeLog.diff?tr1=1.114&tr2=1.115&r1=text&r2=text

Patches:
Index: emacs/lisp/mh-e/ChangeLog
diff -u emacs/lisp/mh-e/ChangeLog:1.114 emacs/lisp/mh-e/ChangeLog:1.115
--- emacs/lisp/mh-e/ChangeLog:1.114     Sat Jan 14 02:05:23 2006
+++ emacs/lisp/mh-e/ChangeLog   Sat Jan 14 02:10:11 2006
@@ -1,5 +1,10 @@
 2006-01-13  Bill Wohler  <address@hidden>
 
+       * mh-acros.el (require): Added Satyaki's comment regarding what
+       needs to happen to remove this defadvice which caused a little
+       discussion on emacs-devel today (see Subject: mh-e/mh-acros.el
+       advices `require' incorrectly).
+
        * mh-search.el (mh-index-next-result-function): Add format to
        docstring.
        (mh-mairix-next-result): Use nil instead of () which doesn't stand
Index: emacs/lisp/mh-e/mh-acros.el
diff -u emacs/lisp/mh-e/mh-acros.el:1.13 emacs/lisp/mh-e/mh-acros.el:1.14
--- emacs/lisp/mh-e/mh-acros.el:1.13    Wed Jan 11 21:02:35 2006
+++ emacs/lisp/mh-e/mh-acros.el Sat Jan 14 02:10:11 2006
@@ -150,6 +150,9 @@
                           (list 'nth ,x z)))
        (quote ,struct-name))))
 
+;; A better solution would be to use Stefan's change in bytecomp.el.
+;; If it were checked in, we can drop the advice to require and it
+;; will make things nicer elsewhere too.
 (defadvice require (around mh-prefer-el activate)
   "Modify `require' to load uncompiled MH-E files."
   (or (featurep (ad-get-arg 0))