[Emacs-commit] emacs/lisp/mh-e mh-utils.el ChangeLog

[Bill Wohler]

CVSROOT:        /cvsroot/emacs
Module name:    emacs
Branch:         
Changes by:     Bill Wohler <address@hidden>    06/01/11 08:58:02

Modified files:
        lisp/mh-e      : mh-utils.el ChangeLog 

Log message:
        (mh-x-image-url-cache-canonicalize): Use url-hexify-string to remove
        special characters from filenames (closes SF #1396499).

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/emacs/emacs/lisp/mh-e/mh-utils.el.diff?tr1=1.35&tr2=1.36&r1=text&r2=text
http://cvs.savannah.gnu.org/viewcvs/emacs/emacs/lisp/mh-e/ChangeLog.diff?tr1=1.107&tr2=1.108&r1=text&r2=text

Patches:
Index: emacs/lisp/mh-e/ChangeLog
diff -u emacs/lisp/mh-e/ChangeLog:1.107 emacs/lisp/mh-e/ChangeLog:1.108
--- emacs/lisp/mh-e/ChangeLog:1.107     Wed Jan 11 07:46:57 2006
+++ emacs/lisp/mh-e/ChangeLog   Wed Jan 11 08:58:02 2006
@@ -1,7 +1,14 @@
+2006-01-11  Bill Wohler  <address@hidden>
+
+       * mh-utils.el (mh-x-image-url-cache-canonicalize): Use
+       url-hexify-string to remove special characters from filenames
+       (closes SF #1396499).
+
 2006-01-10  Bill Wohler  <address@hidden>
 
        * mh-comp.el (mh-insert-letter): If you choose a different folder,
-       the cur message is used (closes SF #1205890).
+       the cur message is used. Sync docstring with manual (closes SF
+       #1205890).
 
        * mh-mime.el (mh-compose-forward): Use standard range argument
        instead of messages. Use more powerful mh-read-range instead of
Index: emacs/lisp/mh-e/mh-utils.el
diff -u emacs/lisp/mh-e/mh-utils.el:1.35 emacs/lisp/mh-e/mh-utils.el:1.36
--- emacs/lisp/mh-e/mh-utils.el:1.35    Tue Jan 10 23:55:42 2006
+++ emacs/lisp/mh-e/mh-utils.el Wed Jan 11 08:58:02 2006
@@ -1489,12 +1489,16 @@
 
 (defun mh-x-image-url-cache-canonicalize (url)
   "Canonicalize URL.
-Replace the ?/ character with a ?! character and append .png."
-   (format "%s/%s.png" mh-x-image-cache-directory
+Replace the ?/ character with a ?! character and append .png.
+Also replaces special characters with `url-hexify-string' since
+not all characters, such as :, are legal within Windows
+filenames. See URL 
`http://msdn.microsoft.com/library/default.asp?url=/library/en-us/fileio/fs/naming_a_file.asp'."
+  (format "%s/%s.png" mh-x-image-cache-directory
+          (url-hexify-string
            (with-temp-buffer
              (insert url)
              (mh-replace-string "/" "!")
-             (buffer-string))))
+             (buffer-string)))))
 
 (defun mh-x-image-set-download-state (file data)
   "Setup a symbolic link from FILE to DATA."