[debbugs-tracker] bug#35879: closed ([PATCH] tests: init: use $PATH_SEPARATOR instead of hard-coded colon(:))

[GNU bug Tracking System]

Your message dated Fri, 24 May 2019 13:38:16 -0700
with message-id <address@hidden>
and subject line Re: [bug-diffutils] bug#35879: [PATCH] tests: init: use 
$PATH_SEPARATOR instead of hard-coded colon(:)
has caused the debbugs.gnu.org bug report #35879,
regarding [PATCH] tests: init: use $PATH_SEPARATOR instead of hard-coded 
colon(:)
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
35879: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35879
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] tests: init: use $PATH_SEPARATOR instead of hard-coded colon(:)
>
>
>
>
> Date: 
>
> Fri, 24 May 2019 18:38:53 +0900
>
>
>
>
> On OS/2, a path separator is semi-colon(;) not colon(:).
>
> * tests/init.cfg: Replace hard-coded colon(:) with $PATH_SEPARATOR.
> ---
>  tests/init.cfg | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tests/init.cfg b/tests/init.cfg
> index d563156..c1f7941 100644
> --- a/tests/init.cfg
> +++ b/tests/init.cfg
> @@ -33,7 +33,7 @@ sanitize_path_()
>    # FIXME: remove double quotes around $IFS when all tests use init.sh.
>    # They constitute a work-around for a bug in FreeBSD 8.1's /bin/sh.
>    local saved_IFS="$IFS"
> -    IFS=:
> +    IFS=$PATH_SEPARATOR
>      set -- $PATH
>    IFS=$saved_IFS
>  
> @@ -44,14 +44,14 @@ sanitize_path_()
>      test -z "$d" && d1=. || d1=$d
>      if ls -d "$d1/." > /dev/null 2>&1; then
>        new_path="$new_path$colon$d"
> -      colon=':'
> +      colon=$PATH_SEPARATOR
>      fi
>    done
>  
>    for d in /sbin /usr/sbin ; do
> -    case ":$new_path:" in
> -      *:$d:*) ;;
> -      *) new_path="$new_path:$d" ;;
> +    case "$PATH_SEPARATOR$new_path$PATH_SEPARATOR" in
> +      *$PATH_SEPARATOR$d$PATH_SEPARATOR*) ;;
> +      *) new_path="$new_path$PATH_SEPARATOR$d" ;;
>      esac
>    done
>  
> -- 
> 2.13.3
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug-diffutils] bug#35879: [PATCH] tests: init: use $PATH_SEPARATOR instead of hard-coded colon(:)
>
>
>
>
> Date: 
>
> Fri, 24 May 2019 13:38:16 -0700
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0
>
>
>
>
> Thanks, I installed that. You might consider attaching git-format 
> patches instead of sending them directly, as gmail seems to be altering 
> the "From:" line.
>
>
> --- End Message ---