[debbugs-tracker] bug#35656: closed ([PATCH] services: mcron: Log to a file.)

[GNU bug Tracking System]

Your message dated Mon, 13 May 2019 00:14:26 +0100
with message-id <address@hidden>
and subject line Re: [bug#35656] [PATCH] services: mcron: Log to a file.
has caused the debbugs.gnu.org bug report #35656,
regarding [PATCH] services: mcron: Log to a file.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
35656: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35656
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] services: mcron: Log to a file.
>
>
>
>
> Date: 
>
> Thu,  9 May 2019 18:40:32 +0100
>
>
>
>
> This makes it easier to read the output, as it's recorded in a file.
>
> * gnu/services/mcron.scm (mcron-shepherd-services): Add #:log-file to
> make-forkexec-constructor.
> ---
>  gnu/services/mcron.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/services/mcron.scm b/gnu/services/mcron.scm
> index 1b232b6cba..fd84589c19 100644
> --- a/gnu/services/mcron.scm
> +++ b/gnu/services/mcron.scm
> @@ -121,7 +121,9 @@ files."
>                          (cons* "GUILE_AUTO_COMPILE=0"
>                                 "PATH=/run/current-system/profile/bin"
>                                 (remove (cut string-prefix? "PATH=" <>)
> -                                       (environ)))))
> +                                       (environ)))
> +
> +                        #:log-file "/var/log/mcron.log"))
>                (stop #~(make-kill-destructor))
>  
>                (actions
> -- 
> 2.21.0
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#35656] [PATCH] services: mcron: Log to a file. Date: Mon, 13 May 2019 00:14:26 +0100 User-agent: mu4e 1.2.0; emacs 26.2

Ludovic Courtès <address@hidden> writes:

> Hi,
>
> Christopher Baines <address@hidden> skribis:
>
>> This makes it easier to read the output, as it's recorded in a file.
>>
>> * gnu/services/mcron.scm (mcron-shepherd-services): Add #:log-file to
>> make-forkexec-constructor.
>
> Good idea, LGTM!

I've pushed this to master now, thanks for taking a look :)

signature.asc
Description: PGP signature

--- End Message ---