[debbugs-tracker] bug#35652: closed ([PATCH] services: dhcp-client: Ignore non-ARP network interfaces.)

[GNU bug Tracking System]

Your message dated Thu, 09 May 2019 20:12:54 +0200
with message-id <address@hidden>
and subject line Re: [bug#35652] [PATCH] services: dhcp-client: Ignore non-ARP 
network interfaces.
has caused the debbugs.gnu.org bug report #35652,
regarding [PATCH] services: dhcp-client: Ignore non-ARP network interfaces.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
35652: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35652
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] services: dhcp-client: Ignore non-ARP network interfaces. Date: Thu, 09 May 2019 17:30:17 +0200 User-agent: Notmuch/0.28.3 (https://notmuchmail.org) Emacs/26.2 (x86_64-pc-linux-gnu)

Guix,

While testing #35563, I found that "dhcp-client" does not work on a
kernel that has CONFIG_IPV6_SIT=y.

The reason is that the system has a virtual "sit0" interface that is not
capable of ARP traffic, which dhclient does not approve of:

May  9 16:18:37 localhost dhclient: Unsupported device type 776 for "sit0"

You can `modprobe sit` on your system if you want to reproduce the
failure.

The attached patch solves it for me.

0001-services-dhcp-client-Ignore-interfaces-that-are-not-.patch
Description: Text Data

signature.asc
Description: PGP signature

--- End Message ---

--- Begin Message --- Subject: Re: [bug#35652] [PATCH] services: dhcp-client: Ignore non-ARP network interfaces. Date: Thu, 09 May 2019 20:12:54 +0200 User-agent: Notmuch/0.28.3 (https://notmuchmail.org) Emacs/26.2 (x86_64-pc-linux-gnu)

Ludovic Courtès <address@hidden> writes:

> Hi Marius,
>
> Good catch!
>
> Marius Bakke <address@hidden> skribis:
>
>> From 7724f24443392fdfc2c075909d9b64350f6578b2 Mon Sep 17 00:00:00 2001
>> From: Marius Bakke <address@hidden>
>> Date: Thu, 9 May 2019 17:03:03 +0200
>> Subject: [PATCH] services: dhcp-client: Ignore interfaces that are not ARP
>>  capable.
>>
>> * guix/build/syscalls.scm (IFF_NOARP): New variable.
>> (arp-network-interface?): New public variable.
>> * gnu/services/networking.scm (dhcp-client-service-type): Filter interfaces
>> that do not support the ARP protocol.
>
> Could you make it two patches (one for syscalls.scm, and another one for
> the rest)?
>
> Otherwise LGTM, thank you!

Thanks for the amazingly fast review :-)

Pushed in a0dc97a5..6c2180f5.

signature.asc
Description: PGP signature

--- End Message ---