[debbugs-tracker] bug#35593: closed ([PATCH] uuid: Pad resulting FAT uuid string with leading zeroes.)

[GNU bug Tracking System]

Your message dated Thu, 09 May 2019 12:10:55 +0200
with message-id <address@hidden>
and subject line Re: [bug#35593] [PATCH] uuid: Pad resulting FAT uuid string 
with leading zeroes.
has caused the debbugs.gnu.org bug report #35593,
regarding [PATCH] uuid: Pad resulting FAT uuid string with leading zeroes.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
35593: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35593
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] uuid: Pad resulting FAT uuid string with leading zeroes.
>
>
>
>
> Date: 
>
> Sun,  5 May 2019 23:43:54 +0200
>
>
>
>
> Fixes <https://bugs.gnu.org/35582>.
> Reported by sirgazil <address@hidden>.
>
> * gnu/system/uuid.scm (fat-uuid->string): Pad resulting string with leading
> zeroes.
> ---
>  gnu/system/uuid.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/system/uuid.scm b/gnu/system/uuid.scm
> index f13960c3e9..7204d163d0 100644
> --- a/gnu/system/uuid.scm
> +++ b/gnu/system/uuid.scm
> @@ -175,7 +175,7 @@ ISO9660 UUID representation."
>    "Convert FAT32/FAT16 UUID, a 4-byte bytevector, to its string 
> representation."
>    (let ((high  (bytevector-uint-ref uuid 0 %fat-endianness 2))
>          (low (bytevector-uint-ref uuid 2 %fat-endianness 2)))
> -    (format #f "~:@(~x-~x~)" low high)))
> +    (format #f "~:@(~4,'0x-~4,'0x~)" low high)))
>  
>  (define %fat-uuid-rx
>    (make-regexp "^([[:xdigit:]]{4})-([[:xdigit:]]{4})$"))
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#35593] [PATCH] uuid: Pad resulting FAT uuid string with leading zeroes.
>
>
>
>
> Date: 
>
> Thu, 09 May 2019 12:10:55 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
>
>
>
>
> Hi Danny,
>
> Danny Milosavljevic <address@hidden> skribis:
>
> > Fixes <https://bugs.gnu.org/35582>.
> > Reported by sirgazil <address@hidden>.
> >
> > * gnu/system/uuid.scm (fat-uuid->string): Pad resulting string with leading
> > zeroes.
>
> Bah, I feel guilty: I pushed the same patch with a test as
> 6c5790a2faf8ffc401e43b13425a707394e40874, and only now do I notice that
> you had fixed it too.  My apologies!
>
> Perhaps in the future you should send the patch directly in the bug
> report?  That would increase the likelihood that I’ll notice and won’t
> duplicate work.
>
> (Perhaps in the future I should also pay more attention to email…
> tricky!)
>
> Ludo’.
>
>
> --- End Message ---