emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#34479: closed (Incorrect classification of message


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#34479: closed (Incorrect classification of messages in compilation-mode buffer)
Date: Fri, 15 Feb 2019 08:03:02 +0000

Your message dated Fri, 15 Feb 2019 10:02:19 +0200
with message-id <address@hidden>
and subject line Re: bug#34479: Incorrect classification of messages in 
compilation-mode buffer
has caused the debbugs.gnu.org bug report #34479,
regarding Incorrect classification of messages in compilation-mode buffer
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
34479: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34479
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: Incorrect classification of messages in compilation-mode buffer Date: Thu, 14 Feb 2019 16:00:08 +0000 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0
Reproduce:

- Open the attached test program compilation_test.c in Emacs
- M-x compile
- Enter compile command "gcc -c compilation_test.c"

In the resulting *compilation* buffer, there should be a mixture of "error", "warning" and "note" messages. Trouble is they're all parsed as errors - hence they're all coloured in red, and querying any one's type by moving point onto it and evaluating "(compilation--message->type (get-text-property (point) 'compilation-message))" always returns 2, though warnings should return 1 and notes should return 0. Commands that jump between previous/next error also behave correspondingly wrongly.

Fix:

The attached fix_compilation_message_type.patch, applied to Git master, fixes it for me.

It seems like the old code was accidentally using the same variable for the TYPE field of the current rule from compilation-error-regexp-alist, and in an inner loop, the actual type that the current message from the compilation buffer was resolved to be, so the resolved type of the first message tends to get carried down into the following ones.

Daniel

Attachment: compilation_test.c
Description: Text Data


--- End Message ---
--- Begin Message --- Subject: Re: bug#34479: Incorrect classification of messages in compilation-mode buffer Date: Fri, 15 Feb 2019 10:02:19 +0200
> From: Daniel Lopez <address@hidden>
> Date: Thu, 14 Feb 2019 16:05:10 +0000
> 
> Argh, I forgot to attach the patch. Here it is!

Thanks.  This is a relatively recent regression, so I pushed it to the
emacs-26 branch.

Please in the future include a ChangeLog-style commit log message with
your patches.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]