[debbugs-tracker] bug#33398: closed (26.1, netbsd-8; Hi Lock Faces, Hi Green B, default setting suggestion)

[GNU bug Tracking System]

Your message dated Fri, 21 Dec 2018 01:01:00 +0200
with message-id <address@hidden>
and subject line Re: bug#33398: 26.1, netbsd-8; Hi Lock Faces, Hi Green B, 
default setting suggestion
has caused the debbugs.gnu.org bug report #33398,
regarding 26.1, netbsd-8; Hi Lock Faces, Hi Green B, default setting suggestion
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
33398: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33398
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 26.1, netbsd-8; Hi Lock Faces, Hi Green B, default setting suggestion
>
>
>
>
> Date: 
>
> Thu, 15 Nov 2018 23:58:13 +1100
>
>
>
>
> Hello,
>
> This is a suggestion for a reasonable default fore/background color combo.
>
> Run: 
>   emacs -Q
>
> See:
>   Customize Group: Hi Lock Faces
>   Hi Green B
>
> I see:
>   foreground:green1 
>   background:white (which I guess is a received setting from somewhere else)
>
> For me, this is a very difficult combo to see. 
>
> I’d like to suggest the default to be for `Hi Green B':
>
>   foreground:darkcyan
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#33398: 26.1, netbsd-8; Hi Lock Faces, Hi Green B, default setting suggestion
>
>
>
>
> Date: 
>
> Fri, 21 Dec 2018 01:01:00 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu)
>
>
>
>
> >> > (defface hi-redgold
> >> >   '((((min-colors 8)) (:background "red"))
> >> >     (t (:background "gold")))
> >> >   "Face for hi-lock mode."
> >> >   :group 'hi-lock-faces)
> >> >
> >> > I see no reason to use "red" on 16-color terminals, nor "orange" on
> >> > color TTYs with at least 88 colors.  The translation of "gold" should
> >> > be good enough in those cases.  Isn't it?
> >>
> >> I tried, and it used "red" even on 88-colors.
> >
> > I don't have access to such a terminal, but on a 16-color TTY "gold"
> > displays as bright yellow, which is definitely not red.  So I'm
> > surprised you see red on a 88-color TTY.
>
> Actually, I meant that I see red on a 88-color graphical display.
>
> >> But given that LightSalmon is a good choice, I copied the same
> >> definitions from other faces, substituted with new colors and they
> >> look good on all environments:
> >>
> >> (defface hi-salmon
> >>   '((((min-colors 88) (background dark))
> >>      (:background "light salmon" :foreground "black"))
> >>     (((background dark)) (:background "red" :foreground "black"))
> >>     (((min-colors 88)) (:background "light salmon"))
> >>     (t (:background "red")))
> >>   "Face for hi-lock mode."
> >>   :group 'hi-lock-faces)
> >>
> >> (defface hi-aquamarine
> >>   '((((min-colors 88) (background dark))
> >>      (:background "aquamarine" :foreground "black"))
> >>     (((background dark)) (:background "blue" :foreground "black"))
> >>     (((min-colors 88)) (:background "aquamarine"))
> >>     (t (:background "blue")))
> >>   "Face for hi-lock mode."
> >>   :group 'hi-lock-faces)
> >
> > Thanks.
>
> Installed to master and closed.  It seems there is no need to update NEWS
> because the users will see themselves two new colors added.
>
>
> --- End Message ---