[debbugs-tracker] bug#33804: closed ([PATCH] * src/editfns.c (insert-char): Skip unnecessary fixnum check)

[GNU bug Tracking System]

Your message dated Wed, 19 Dec 2018 08:57:52 -0800
with message-id <address@hidden>
and subject line [PATCH] * src/editfns.c (insert-char): Skip unnecessary fixnum 
check
has caused the debbugs.gnu.org bug report #33804,
regarding [PATCH] * src/editfns.c (insert-char): Skip unnecessary fixnum check
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
33804: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33804
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] * src/editfns.c (insert-char): Skip unnecessary fixnum check
>
>
>
>
> Date: 
>
> Wed, 19 Dec 2018 10:48:24 -0600
>
>
>
>
> COUNT gets set to 1 when it is passed in as nil, and in that case
> there is no need to check its type.
> ---
>  src/editfns.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/editfns.c b/src/editfns.c
> index 8df4ed107e..9bfab74a9a 100644
> --- a/src/editfns.c
> +++ b/src/editfns.c
> @@ -1471,7 +1471,8 @@ called interactively, INHERIT is t.  */)
>    CHECK_CHARACTER (character);
>    if (NILP (count))
>      XSETFASTINT (count, 1);
> -  CHECK_FIXNUM (count);
> +  else
> +    CHECK_FIXNUM (count);
>    c = XFIXNAT (character);
>
>    if (!NILP (BVAR (current_buffer, enable_multibyte_characters)))
> -- 
> 2.17.1
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] * src/editfns.c (insert-char): Skip unnecessary fixnum check
>
>
>
>
> Date: 
>
> Wed, 19 Dec 2018 08:57:52 -0800
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1
>
>
>
>
> Thanks, I installed that into master in your name.
>
>
>
> --- End Message ---