[debbugs-tracker] bug#33761: closed (Allow split to write into FIFOs)

[GNU bug Tracking System]

Your message dated Sat, 15 Dec 2018 12:20:00 -0800
with message-id <address@hidden>
and subject line Re: bug#33761: Allow split to write into FIFOs
has caused the debbugs.gnu.org bug report #33761,
regarding Allow split to write into FIFOs
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
33761: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33761
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: Allow split to write into FIFOs Date: Sat, 15 Dec 2018 00:00:18 -0800 User-agent: Mutt/1.10.1 (2018-07-13)

TL;DR: Attached: Patch to allow split to write into FIFOs.



Currently, split fails when its output files are FIFOs because
FIFOs cannot be ftruncate()d.  Split exits with this error message:

  split: xaa: error truncating: Invalid argument

The attached patch causes split to only attempt the ftruncate when its
output is a regular file.

coreutils-split-into-fifos.patch
Description: Text Data

--- End Message ---

--- Begin Message --- Subject: Re: bug#33761: Allow split to write into FIFOs Date: Sat, 15 Dec 2018 12:20:00 -0800 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 Thanks for reporting that. I see similar problems in a couple of other coreutils programs. The style elsewhere seems to be to try ftruncate first, and report an error if it fails only if the file is not one for which POSIX specifies the behavior, so I think it'd be better if 'split' did that too. So I installed the attached patch to fix the problems that I found, and this should fix the bug you reported so I'll close the bug report.

Thanks also for the test case. To install that I'll need a copyright assignment form signed; can you do that for us? If so, please let me know and I'll get the paperwork ball rolling for you.

0001-shred-sort-split-fix-ftruncate-error-reporting.patch
Description: Text Data

--- End Message ---