[debbugs-tracker] bug#33494: closed (25.2; vc-bzr-expanded-log-entry does not honor vc-bzr-log-switches)

[GNU bug Tracking System]

Your message dated Sat, 08 Dec 2018 11:35:44 +0200
with message-id <address@hidden>
and subject line Re: bug#33494: 25.2; vc-bzr-expanded-log-entry does not honor 
vc-bzr-log-switches
has caused the debbugs.gnu.org bug report #33494,
regarding 25.2; vc-bzr-expanded-log-entry does not honor vc-bzr-log-switches
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
33494: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33494
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 25.2; vc-bzr-expanded-log-entry does not honor vc-bzr-log-switches
>
>
>
>
> Date: 
>
> Sat, 24 Nov 2018 23:57:57 +0100
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0
>
>
>
>
> Hello.
>
> In Bzr-Log-View, pressing RET brings up more info about a certain
> revision, but this expanded log entry does not honor customized switches
> for 'bzr log'.  I hacked vc-bzr-expanded-log-entry to consider these
> switches just like vc-bzr-print-log does:
>
> (defun vc-bzr-expanded-log-entry (revision)
>   (with-temp-buffer
>     (apply 'vc-bzr-command "log" t nil nil
>      (append
>       (list "--long" (format "-r%s" revision))
>       (if (stringp vc-bzr-log-switches)
>           (list vc-bzr-log-switches)
>         vc-bzr-log-switches)))
>     (goto-char (point-min))
>     (when (looking-at "^-+\n")
>       ;; Indent the expanded log entry.
>       (indent-region (match-end 0) (point-max) 2)
>       (buffer-substring (match-end 0) (point-max)))))
>
> I don't know a lot of Emacs Lisp, but it does work with 'emacs -q'...
>
> Thanks for you work on Emacs!
> -Steven
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#33494: 25.2; vc-bzr-expanded-log-entry does not honor vc-bzr-log-switches
>
>
>
>
> Date: 
>
> Sat, 08 Dec 2018 11:35:44 +0200
>
>
>
>
> > From: Steven De Herdt <address@hidden>
> > Date: Sat, 24 Nov 2018 23:57:57 +0100
> > 
> > In Bzr-Log-View, pressing RET brings up more info about a certain
> > revision, but this expanded log entry does not honor customized switches
> > for 'bzr log'.  I hacked vc-bzr-expanded-log-entry to consider these
> > switches just like vc-bzr-print-log does:
>
> Thanks, pushed to the master branch.
>
>
> --- End Message ---