[debbugs-tracker] bug#33460: closed (24.4; Eshell histfile symlinks not followed)

[GNU bug Tracking System]

Your message dated Sat, 08 Dec 2018 11:15:27 +0200
with message-id <address@hidden>
and subject line Re: bug#33460: 24.4; Eshell histfile symlinks not followed
has caused the debbugs.gnu.org bug report #33460,
regarding 24.4; Eshell histfile symlinks not followed
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
33460: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33460
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: 24.4; Eshell histfile symlinks not followed Date: Wed, 21 Nov 2018 23:09:16 +0000

If the file named by the value of option `eshell-history-file-name' is
a symbolic link, then it will be replaced and overwritten instead. It
should be dereferenced (followed) first, and its target file should be
replaced and overwritten.

The attached patch uses function `file-truename' to fix this. The
patch was made using source cloned from git savannah HEAD today, which
I think is version 26.1.90, based on ChangeLog.3 in the cloned repo.



In GNU Emacs 24.4.1 (x86_64-pc-linux-gnu, GTK+ Version 3.14.5)
of 2017-09-12 on hullmann, modified by Debian
Windowing system distributor `The X.Org Foundation', version 11.0.11604000
System Description: LMDE 2 Betsy


-- 
Phil Hudson                  http://hudson-it.ddns.net
Pretty Good Privacy (PGP) ID: 0x4E482F85

eshellResolveHistFile.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#33460: 24.4; Eshell histfile symlinks not followed
>
>
>
>
> Date: 
>
> Sat, 08 Dec 2018 11:15:27 +0200
>
>
>
>
> > From: Philip Hudson <address@hidden>
> > Date: Wed, 21 Nov 2018 23:09:16 +0000
> > 
> > If the file named by the value of option `eshell-history-file-name' is
> > a symbolic link, then it will be replaced and overwritten instead. It
> > should be dereferenced (followed) first, and its target file should be
> > replaced and overwritten.
> > 
> > The attached patch uses function `file-truename' to fix this. The
> > patch was made using source cloned from git savannah HEAD today, which
> > I think is version 26.1.90, based on ChangeLog.3 in the cloned repo.
>
> Thanks, pushed to the master branch, to appear in Emacs 27.1.
>
> Please in the future provide a ChangeLog-style commit log entry for
> your changes; see CONTRIBUTE for the details.
>
> Also, user-visible behavior changes need to be called out in NEWS, and
> if necessary also in the relevant Texinfo manual(s).
>
>
> --- End Message ---