emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#33263: closed (27.0.50; Tidying up Gnus modes)


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#33263: closed (27.0.50; Tidying up Gnus modes)
Date: Fri, 23 Nov 2018 17:46:02 +0000

Your message dated Fri, 23 Nov 2018 09:45:24 -0800
with message-id <address@hidden>
and subject line Re: bug#33263: 27.0.50; Tidying up Gnus modes
has caused the debbugs.gnu.org bug report #33263,
regarding 27.0.50; Tidying up Gnus modes
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
33263: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33263
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: 27.0.50; Tidying up Gnus modes Date: Sun, 04 Nov 2018 18:53:41 -0800
The attached patch does a couple of things to clean up Gnus's various
major modes:

- Creates a do-nothing `gnus-mode', derived from `special-mode', to
  serve as parent mode for all the other major modes. This isn't so
  important, but sometimes it would be nice to do (derived-mode-p
  'gnus-mode).
- Derives everything from `gnus-mode', and turns a couple of modes from
  functions that manually set up modes into proper calls to
  `define-derived-mode'.
- Removes code like "(setq buffer-read-only t)", as that's automatically
  done by `special-mode'.
- Where appropriate, deletes custom definitions for gnus-*-mode-hook, as
  these hooks are already automatically created by the define-mode
  calls. (Maybe this removal isn't worth doing?)

This patch probably needs more testing, but I'm floating it first for
any comments.

Eric

In GNU Emacs 27.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.1)
 of 2018-10-31 built on slip

Attachment: 0001-Provide-new-gnus-mode-derive-all-gnus-major-modes-fr.patch
Description: Text Data


--- End Message ---
--- Begin Message --- Subject: Re: bug#33263: 27.0.50; Tidying up Gnus modes Date: Fri, 23 Nov 2018 09:45:24 -0800 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
Okay, I've been running this for more than a week and it seems fine so
far. I'll push it, and watch for repercussions.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]