[debbugs-tracker] bug#33335: closed (26; Doc strings of `trash-directory' and `move-file-to-trash')

[GNU bug Tracking System]

Your message dated Sat, 10 Nov 2018 22:18:00 +0200
with message-id <address@hidden>
and subject line Re: bug#33335: 26; Doc strings of `trash-directory' and 
`move-file-to-trash'
has caused the debbugs.gnu.org bug report #33335,
regarding 26; Doc strings of `trash-directory' and `move-file-to-trash'
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
33335: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33335
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 26; Doc strings of `trash-directory' and `move-file-to-trash'
>
>
>
>
> Date: 
>
> Sat, 10 Nov 2018 11:12:40 -0800 (PST)
>
>
>
>
> Both of these doc strings seem to say that if function
> `system-move-file-to-trash' is defined then it is used, regardless of
> the value of option `trash-directory'.
>
> A cursory look at the code defining `move-file-to-trash' suggests
> otherwise.  And that would seem to make sense, giving users a way
> to customize the directory in all cases.
>
> Are the doc strings wrong, or am I misreading the code?
>
> (cond (trash-directory
>        ;; If `trash-directory' is non-nil, move the file there.
>        ...)
>       ;; If `system-move-file-to-trash' is defined, use it.
>       ((fboundp 'system-move-file-to-trash)
>        (system-move-file-to-trash filename))
>       ...)
>
>
> In GNU Emacs 26.1 (build 1, x86_64-w64-mingw32)
>  of 2018-05-30
> Repository revision: 07f8f9bc5a51f5aa94eb099f3e15fbe0c20ea1ea
> Windowing system distributor `Microsoft Corp.', version 10.0.16299
> Configured using:
>  `configure --without-dbus --host=x86_64-w64-mingw32
>  --without-compress-install 'CFLAGS=-O2 -static -g3''
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#33335: 26; Doc strings of `trash-directory' and `move-file-to-trash'
>
>
>
>
> Date: 
>
> Sat, 10 Nov 2018 22:18:00 +0200
>
>
>
>
> > Date: Sat, 10 Nov 2018 11:12:40 -0800 (PST)
> > From: Drew Adams <address@hidden>
> > 
> > Both of these doc strings seem to say that if function
> > `system-move-file-to-trash' is defined then it is used, regardless of
> > the value of option `trash-directory'.
> > 
> > A cursory look at the code defining `move-file-to-trash' suggests
> > otherwise.  And that would seem to make sense, giving users a way
> > to customize the directory in all cases.
> > 
> > Are the doc strings wrong, or am I misreading the code?
>
> It's a (subtle) bug, which I just fixed.
>
> Thanks.
>
>
> --- End Message ---