[debbugs-tracker] bug#33095: closed ([PATCH] Add support in emacsclient for EMACS_SOCKET_NAME)

[GNU bug Tracking System]

Your message dated Sat, 27 Oct 2018 12:27:29 +0300
with message-id <address@hidden>
and subject line Re: bug#33095: [PATCH] Add support in emacsclient for 
EMACS_SOCKET_NAME
has caused the debbugs.gnu.org bug report #33095,
regarding [PATCH] Add support in emacsclient for EMACS_SOCKET_NAME
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
33095: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33095
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] Add support in emacsclient for EMACS_SOCKET_NAME Date: Fri, 19 Oct 2018 09:45:57 -0400

This patch implements EMACS_SOCKET_NAME in emacsclient, providing the

same sort of "set the argument from the environment" feature for the

socket name as for other features.

I use this to enable a stable, consistent path on a set of machines

where I use Unix domain socket forwarding and TRAMP to enable easy

emacsclient use from within tmux -- where I can't easily know the UID

I'll be logged in as programatically.

While this certainly could be a "you have a configuration problem", the

symmetry with other settings including the TRAMP prefix makes me feel

this is a useful addition -- or at least, not out of line with how

similar options can be configured.

0001-Add-support-in-emacsclient-for-EMACS_SOCKET_NAME.patch
Description: Binary data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#33095: [PATCH] Add support in emacsclient for EMACS_SOCKET_NAME
>
>
>
>
> Date: 
>
> Sat, 27 Oct 2018 12:27:29 +0300
>
>
>
>
> > From: Daniel Pittman <address@hidden>
> > Date: Fri, 19 Oct 2018 09:45:57 -0400
> > 
> > This patch implements EMACS_SOCKET_NAME in emacsclient, providing the
> > same sort of "set the argument from the environment" feature for the
> > socket name as for other features.
>
> Thanks, pushed to the master branch.
>
> A few minor nits for the future:
>
> > If the `--socket-name` argument is unspecified, the environment
> > variable `EMACS_SOCKET_NAME` is now consulted with the same
>
> We don't use the markdown-style quoting `like this`, we use quoting
> 'like this' instead.
>
> > semantics. This mirrors the behavior of the `--server-file` argument,
>
> Please leave 2 spaces between sentences in documentation and comments.
>
> Finally, it looks like your copyright assignment is only for rcp.el
> and for Gnus, so I think we will need a general Emacs assignment to
> accept your future contributions.  Please write to
> address@hidden and ask him whether this is indeed so, as I
> could be mistaken.
>
>
> --- End Message ---