[debbugs-tracker] bug#32904: closed ([PATCH] build-system/asdf: Properly handle dependency specification casing.)

[GNU bug Tracking System]

Your message dated Tue, 02 Oct 2018 14:06:26 +0200
with message-id <address@hidden>
and subject line Re: [bug#32904] [PATCH] build-system/asdf: Properly handle 
dependency specification casing.
has caused the debbugs.gnu.org bug report #32904,
regarding [PATCH] build-system/asdf: Properly handle dependency specification 
casing.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
32904: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=32904
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] build-system/asdf: Properly handle dependency specification casing.
>
>
>
>
> Date: 
>
> Tue, 2 Oct 2018 05:17:03 -0400
>
>
>
>
> From fd4047ab93f9be94ddfeef48248fca6a0580131f Mon Sep 17 00:00:00 2001
> From: Andy Patterson <address@hidden>
> Date: Tue, 2 Oct 2018 04:57:31 -0400
> Subject: [PATCH] build-system/asdf: Properly handle dependency
> specification casing.
>
> * guix/build/lisp-utils.scm (normalize-dependency): Modify match
> clauses to match the upper-case symbols that lisp produces.
> ---
>  guix/build/lisp-utils.scm | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/guix/build/lisp-utils.scm b/guix/build/lisp-utils.scm
> index 6470cfec9..3f5cdf86b 100644
> --- a/guix/build/lisp-utils.scm
> +++ b/guix/build/lisp-utils.scm
> @@ -84,11 +84,12 @@
>  (define (normalize-dependency dependency)
>    "Normalize the name of DEPENDENCY.  Handles dependency definitions
> of the dependency-def form described by
> -<https://common-lisp.net/project/asdf/asdf.html#The-defsystem-grammar>."
> +<https://common-lisp.net/project/asdf/asdf.html#The-defsystem-grammar>.
> +Assumes that any symbols in DEPENDENCY will be in upper-case."
>    (match dependency
> -    ((':version name rest ...)
> +    ((':VERSION name rest ...)
>       `(:version ,(normalize-string name) ,@rest))
> -    ((':feature feature-specification dependency-specification)
> +    ((':FEATURE feature-specification dependency-specification)
>       `(:feature
>         ,feature-specification
>         ,(normalize-dependency dependency-specification)))
> -- 
> 2.19.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#32904] [PATCH] build-system/asdf: Properly handle dependency specification casing.
>
>
>
>
> Date: 
>
> Tue, 02 Oct 2018 14:06:26 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
>
>
>
>
> Andy Patterson <address@hidden> skribis:
>
> > From fd4047ab93f9be94ddfeef48248fca6a0580131f Mon Sep 17 00:00:00 2001
> > From: Andy Patterson <address@hidden>
> > Date: Tue, 2 Oct 2018 04:57:31 -0400
> > Subject: [PATCH] build-system/asdf: Properly handle dependency
> > specification casing.
> >
> > * guix/build/lisp-utils.scm (normalize-dependency): Modify match
> > clauses to match the upper-case symbols that lisp produces.
>
> Applied, thanks!
>
> Ludo'.
>
>
> --- End Message ---