[debbugs-tracker] bug#31704: closed (26.1; tramp-remote-path/shell: broken executable completion)

[GNU bug Tracking System]

Your message dated Mon, 10 Sep 2018 09:54:43 +0200
with message-id <address@hidden>
and subject line Re: bug#31704: fixed commit not handle eshell-path-env 
properly in Windows platform
has caused the debbugs.gnu.org bug report #31704,
regarding 26.1; tramp-remote-path/shell: broken executable completion
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
31704: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=31704
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 26.1; tramp-remote-path/shell: broken executable completion
>
>
>
>
> Date: 
>
> Sun, 03 Jun 2018 21:32:09 -0400
>
>
>
>
> The issue lies in shell--command-completion-data which is called
> by shell-command-completion, it only checks directories in
> exec-path (local) rather than tramp-remote-path. This bug also
> leaks the local exec-path to the remote server.
>
> To reproduce:
>
> emacs -Q
>
> Evaluate:
> (require 'tramp)
>
> ;; For debugging
> (setq tramp-persistency-file-name nil
>       tramp-verbose 10)
>
> (add-to-list 'tramp-remote-path 'tramp-own-remote-path)
>
> ;; Assuming an account 'chris' exists at server 'remote',
> ;; to see the issue clearly make sure that there exists
> ;; a directory in the remote server PATH (e.g. ~/bin/)
> ;; but NOT in exec-path.
>
> (let ((default-directory "/ssh:address@hidden:"))
>   (shell "*remote*"))
>
> ;; Assuming executable 'testbin' exists in remote server ~/bin/
> ;; and not inside any directory in exec-path:
>
> remote$ testb<TAB> ;; No completion
>
> M-:
> (add-to-list 'exec-path "~/bin/")
>
> remote$ testb<TAB> ;; Completes fine
>
> If one checks the tramp debug buffer, one will see tramp
> checking (and leaking information to the remote server)
> all the directories that exist in the local exec-path.
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#31704: fixed commit not handle eshell-path-env properly in Windows platform
>
>
>
>
> Date: 
>
> Mon, 10 Sep 2018 09:54:43 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
>
>
>
>
> Version: 27.1
>
> Tao Fang <address@hidden> writes:
>
> > Hi, Michael
>
> Hi,
>
> >  I can confirm this bug was fixed in your commit and second problem
> > fixed either, thanks!
>
> Thanks for your confirmation, I'm closing the bug.
>
> > Best regards,
>
> Best regards, Michael. 
>
>
> --- End Message ---