[debbugs-tracker] bug#32116: closed (Allow bytevector as content of plain-file for binary data.)

[GNU bug Tracking System]

Your message dated Thu, 12 Jul 2018 06:30:31 +0200
with message-id <address@hidden>
and subject line Re: [bug#32117] [PATCH 1/2] store: Add `binary-file'.
has caused the debbugs.gnu.org bug report #32116,
regarding Allow bytevector as content of plain-file for binary data.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
32116: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=32116
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> Allow bytevector as content of plain-file for binary data.
>
>
>
>
> Date: 
>
> Tue, 10 Jul 2018 19:41:26 +0200
>
>
>
>
> Currently, plain-file does not handle binary content correctly.  As discussed
> on IRC[0] I added bytevector support to plain-file.
>
> This allows for using a package source directly from git, doing something like
>
> --8<---------------cut here---------------start------------->8---
> (define (command->bytevector command)
>   (let ((port (apply open-pipe* OPEN_READ command)))
>     (let ((output (get-bytevector-all port)))
>       (close-port port)
>       output)))
>
> (define-public hello-git
>   (package
>     (name "hello")
>     (version "git")
>     (source (let* ((commit "stable-2.0")
>                    (content (command->bytevector
>                              `("git" "archive" "--format" "tar" "--prefix"
>                                ,(string-append commit "/") ,commit)))
>                    (file-name (string-append "hello-" commit)))
>               (plain-file file-name content)))
>     ...
>     ))
> --8<---------------cut here---------------end--------------->8---
>
> Greetings,
> janneke
>
> [0] https://gnunet.org/bot/log/guix/2018-07-10#T1763807
>
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#32117] [PATCH 1/2] store: Add `binary-file'.
>
>
>
>
> Date: 
>
> Thu, 12 Jul 2018 06:30:31 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
>
>
>
>
> Ludovic Courtès writes:
>
> >> address@hidden {Monadic Procedure} binary-file* @var{name} @var{data} @dots{}
> >
> > There’s no ‘*’ in the actual procedure name.
> >
> > Also, could you move this @deffn to “The Store Monad”, right after
> > ‘text-file’?
>
> Ah, I based this on the `text-file*' description!  Moved, and rewritten
> as
>
> @deffn {Monadic Procedure} binary-file @var{name} @var{data} address@hidden
> Return as a monadic value the absolute file name in the store of the file
> containing @var{data}, a bytevector.  @var{references} is a list of store
> items that the resulting binary file refers to; it defaults to the empty list.
> @end deffn
>
> > Apart from that it LGTM, thanks!
>
> Pushed to master as  f3a422511f793fb6c6cfeec2bb8735965a03294a
>
> janneke
>
> -- 
> Jan Nieuwenhuizen <address@hidden> | GNU LilyPond http://lilypond.org
> Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com
>
>
> --- End Message ---