emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#31466: closed (27.0.50; customize-apropos: Separat


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#31466: closed (27.0.50; customize-apropos: Separate package name from its description)
Date: Fri, 15 Jun 2018 07:25:02 +0000

Your message dated Fri, 15 Jun 2018 16:23:49 +0900
with message-id <address@hidden>
and subject line Re: bug#31466: 27.0.50; customize-apropos: Separate package 
name from its description
has caused the debbugs.gnu.org bug report #31466,
regarding 27.0.50; customize-apropos: Separate package name from its description
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
31466: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=31466
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: 27.0.50; customize-apropos: Separate package name from its description Date: Wed, 16 May 2018 12:51:01 +0900

emacs -Q -l dired-x
M-x customize-apropos dired-x RET

;; Last line of the buffer is:
Dired XExtended directory editing (dired-x).

;; It reads better if the package name is separated from
;; the package description.  For instance:

Dired X: Extended directory editing (dired-x).

;; Following patch shows the line as:
Dired X:Extended directory editing (dired-x).

;; Without the extra space because looks a bit ugly in the link.
;; If someone knows a way to add the extra space out of the link,
;; that would be better.

--8<-----------------------------cut here---------------start------------->8---
commit 2edea58d78914063bb56270774b5e02d8a1a55af
Author: Tino Calancha <address@hidden>
Date:   Wed May 16 12:46:09 2018 +0900

    customize-apropos: Separate package name from its description
    
    * lisp/cus-edit.el (custom-buffer-create-internal): Separate
    package name from its description with a colon.

diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el
index a12897e799..0a596ab331 100644
--- a/lisp/cus-edit.el
+++ b/lisp/cus-edit.el
@@ -1711,8 +1711,10 @@ custom-buffer-create-internal
                          (message "Creating customization items ...%2d%%"
                                   (floor (* 100.0 count) length))
                          (widget-create (nth 1 entry)
-                                        :tag (custom-unlispify-tag-name
-                                              (nth 0 entry))
+                                        :tag (format "%s%s"
+                                              (custom-unlispify-tag-name
+                                               (nth 0 entry))
+                                              (if (eq (nth 1 entry) 
'custom-group) ":" ""))
                                         :value (nth 0 entry))
                        (setq count (1+ count))
                        (unless (eq (preceding-char) ?\n)

--8<-----------------------------cut here---------------end--------------->8---




--- End Message ---
--- Begin Message --- Subject: Re: bug#31466: 27.0.50; customize-apropos: Separate package name from its description Date: Fri, 15 Jun 2018 16:23:49 +0900 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
Tino Calancha <address@hidden> writes:

>
> I think we can just require
> (eq custom-buffer-style 'links)
> and go ahead indenting the documentation if such condition holds.
>
> Then, we don't need `this-command', so that the doc will be indented
> also in non-interactive calls.
>
> commit dff8d8fb83f2e629e66380554c0b28e68db49868
> Author: Tino Calancha <address@hidden>
> Date:   Thu Jun 7 13:49:53 2018 +0900
>
>     customize-apropos: Separate package name from its description
>     
>     * lisp/cus-edit.el (custom-group-value-create):
>     Always insert documentation indented from its package name (Bug#31466).
>
> diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el
> index a12897e799..ff6a4f6d33 100644
> --- a/lisp/cus-edit.el
> +++ b/lisp/cus-edit.el
> @@ -4145,7 +4145,7 @@ custom-group-value-create
>          ;; Update buttons.
>          (widget-put widget :buttons buttons)
>          ;; Insert documentation.
> -        (if (and (eq custom-buffer-style 'links) (> level 1))
> +        (when (eq custom-buffer-style 'links)
>              (widget-put widget :documentation-indent
>                          custom-group-doc-align-col))
>          (widget-add-documentation-string-button
>
> If people OK with that, I'd like to push this fix.
Pushed fix into master branch as commit
'customize-apropos: Separate package name from its description'
(aeb6b2e31fea5d3fa78e2f8a0895dc86f6b4a7a6)


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]