[debbugs-tracker] bug#31236: closed ([PATCH] Fix pre- and post-command-hook errors in term.el)

[GNU bug Tracking System]

Your message dated Sun, 22 Apr 2018 20:09:22 +0300
with message-id <address@hidden>
and subject line Re: bug#31236: [PATCH] Fix pre- and post-command-hook errors 
in term.el
has caused the debbugs.gnu.org bug report #31236,
regarding [PATCH] Fix pre- and post-command-hook errors in term.el
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
31236: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=31236
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] Fix pre- and post-command-hook errors in term.el Date: Sat, 21 Apr 2018 23:41:51 -0400

As far as I can tell there isn't an existing bug report for this
issue. It is very minor but I have attached a fix. This affects Emacs
26.1-rc1 `term' and `ansi-term'. In char mode term installs functions
in both pre- and post-command-hooks. After the process exits both of
these hooks produce errors and then are removed by Emacs after
printing a message.

Both of these hooks are re-installed when entering char mode and
removing them if they are not present will do nothing. To produce this
change, I took the remove-hook lines used when entering line mode and
placed them in `term-handle-exit'.

To reproduce the issue in 26.1, M-x term, exit the running process and
execute any command (i.e. move point). In *Messages* there should be
the following lines:

Error in pre-command-hook (term-set-goto-process-mark):
(wrong-type-argument processp nil)
Error in post-command-hook (term-goto-process-mark-maybe):
(wrong-type-argument processp nil)

The error seems to come up from `process-mark'. After this change,
these errors no longer appear as the hooks are removed. I have
attached a patch which applies this change to current master.

Thank you,
Karl

0001-Fix-pre-and-post-command-hook-errors-in-term.el.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#31236: [PATCH] Fix pre- and post-command-hook errors in term.el
>
>
>
>
> Date: 
>
> Sun, 22 Apr 2018 20:09:22 +0300
>
>
>
>
> > Date: Sun, 22 Apr 2018 23:48:38 +1200
> > From: Phil Sainty <address@hidden>
> > Cc: bug-gnu-emacs <address@hidden>,
> >       address@hidden
> > 
> > Bug and proposed fix confirmed and tested here.
> > 
> > This was an oversight on my part from #24837.
> > 
> > The suggested patch seems sensible to me.  If others agree, I think
> > this should be committed to the emacs-26 branch.
>
> Pushed, thanks.
>
> Karl, in the future please include a commit log message according to
> the instructions in CONTRIBUTE.  (I fixed that for you this time.)
>
>
> --- End Message ---