[debbugs-tracker] bug#30797: closed ([PATCH 1/2] gnu: Add emacs-exec-path-from-shell)

[GNU bug Tracking System]

Your message dated Fri, 16 Mar 2018 17:13:45 +0300
with message-id <address@hidden>
and subject line Re: [bug#30797] [PATCH 1/2] gnu: Add emacs-exec-path-from-shell
has caused the debbugs.gnu.org bug report #30797,
regarding [PATCH 1/2] gnu: Add emacs-exec-path-from-shell
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
30797: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=30797
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 1/2] gnu: Add emacs-exec-path-from-shell
>
>
>
>
> Date: 
>
> Tue, 13 Mar 2018 16:47:01 +0100
>
>
>
>
> * gnu/packages/emacs.scm (emacs-exec-path-from-shell): New variable.
> ---
>  gnu/packages/emacs.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index c2c162c75..9c9c399fd 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -7361,3 +7361,31 @@ highlighting and indentation support.")
>  @uref{https://www.terraform.io/, Terraform} configuration files.  Most of the
>  functionality is inherited from @code{hcl-mode}.")
>      (license license:gpl3+)))
> +
> +(define-public emacs-exec-path-from-shell
> +  (package
> +    (name "emacs-exec-path-from-shell")
> +    (version "1.11")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://stable.melpa.org/packages/exec-path-from-shell-";
> +             version
> +             ".el"))
> +       (sha256
> +        (base32
> +         "03qjgb81cq1l3j54lvlf98r75vmmgd06mj6qh5wa6mz4xzp4w26r"))))
> +    (build-system emacs-build-system)
> +    (home-page
> +     "https://github.com/purcell/exec-path-from-shell";)
> +    (synopsis
> +     "Get environment variables such as $PATH from the shell")
> +    (description
> +     "This library allows the user to set Emacs' @code{exec-path} and 
> @code{$PATH}
> +from the shell path, so that @code{shell-command}, @code{compile} and the
> +like work as expected on systems on which Emacs is not guaranteed
> +to inherit a login shell's environment variables.  It also allows other
> +environment variables to be retrieved from the shell, so that Emacs will
> +see the same values you get in a terminal.")
> +    (license license:gpl3+)))
> -- 
> 2.16.2
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#30797] [PATCH 1/2] gnu: Add emacs-exec-path-from-shell Date: Fri, 16 Mar 2018 17:13:45 +0300 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)

Hello Konrad,

Konrad Hinsen <address@hidden> writes:

> * gnu/packages/emacs.scm (emacs-exec-path-from-shell): New variable.
> ---
>  gnu/packages/emacs.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index c2c162c75..35acfdd20 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -7361,3 +7361,28 @@ highlighting and indentation support.")
>  @uref{https://www.terraform.io/, Terraform} configuration files.  Most of the
>  functionality is inherited from @code{hcl-mode}.")
>      (license license:gpl3+)))
> +

[…]

> +    (description
> +     "This library allows the user to set Emacs' @code{exec-path} and

I still think this apostrophe is unnecessary.  I removed it if you don't
mind.  ;-)

-     "This library allows the user to set Emacs' @code{exec-path} and
+     "This library allows the user to set Emacs @code{exec-path} and

[…]


In addition, according to Bash documentation [1] variables don't have
‘$’ in their description.

-    (synopsis "Get environment variables such as $PATH from the shell")
+    (synopsis "Get environment variables such as @var{PATH} from the shell")

- [1]  https://www.gnu.org/software/bash/manual/html_node/Bash-Variables.html


And in the description, we could use address@hidden instead of address@hidden:

-This library allows the user to set Emacs @code{exec-path} and
+This library allows the user to set Emacs @var{exec-path} and

address@hidden from the shell path, so that @code{shell-command},
address@hidden from the shell @var{PATH}, so that @code{shell-command},


Also don't forget a dot at end the in commit message.

    gnu: Add emacs-exec-path-from-shell.


Pushed with changes above as 22d628148ce857b620f5b8e48dc7cabe004313c5

I'll close the bug report.

Thanks,
Oleg.

signature.asc
Description: PGP signature

--- End Message ---