[debbugs-tracker] bug#29567: closed ([PATCH] src/xterm.c: use 'thickness' only in a case of !USE_CAIRO)

[GNU bug Tracking System]

Your message dated Mon, 04 Dec 2017 22:05:20 +0200
with message-id <address@hidden>
and subject line Re: bug#29567: [PATCH] src/xterm.c: use 'thickness' only in a 
case of !USE_CAIRO
has caused the debbugs.gnu.org bug report #29567,
regarding [PATCH] src/xterm.c: use 'thickness' only in a case of !USE_CAIRO
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
29567: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29567
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] src/xterm.c: use 'thickness' only in a case of !USE_CAIRO Date: Tue, 5 Dec 2017 00:11:47 +0600

Hello,

I've attached simple patch with moving of the `thickness` var
(from the x_draw_underwave() src/xterm.c) a little bit below, to get rid of:

xterm.c:3520:61: error: unused variable 'thickness' [-Werror,-Wunused-variable]
  int wave_height = 3 * scale_y, wave_length = 2 * scale_x, thickness = scale_y;

as this variable is used only in a case of !USE_CAIRO

Thank you.

0001-Move-thickness-assignment-where-it-is-used.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#29567: [PATCH] src/xterm.c: use 'thickness' only in a case of !USE_CAIRO
>
>
>
>
> Date: 
>
> Mon, 04 Dec 2017 22:05:20 +0200
>
>
>
>
> > From: Alexander Kuleshov <address@hidden>
> > Date: Tue, 5 Dec 2017 00:11:47 +0600
> > 
> > I've attached simple patch with moving of the `thickness` var
> > (from the x_draw_underwave() src/xterm.c) a little bit below, to get rid of:
> > 
> > xterm.c:3520:61: error: unused variable 'thickness' 
> > [-Werror,-Wunused-variable]
> >   int wave_height = 3 * scale_y, wave_length = 2 * scale_x, thickness = 
> > scale_y;
> > 
> > as this variable is used only in a case of !USE_CAIRO
>
> Thanks.  Did the patched source compile for you in the !USE_CAIRO
> case?  Because 'thickness' needs to be declared as 'int' before it can
> be used.
>
> So I installed a slightly different change to avoid the warning.
>
>
> --- End Message ---