[debbugs-tracker] bug#28593: closed ([PATCH] gnu: openfoam: Clean up to reduce closure.)

[GNU bug Tracking System]

Your message dated Fri, 01 Dec 2017 11:27:57 +0100
with message-id <address@hidden>
and subject line Re: [bug#28593] [PATCH] gnu: openfoam: Clean up to reduce 
closure.
has caused the debbugs.gnu.org bug report #28593,
regarding [PATCH] gnu: openfoam: Clean up to reduce closure.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
28593: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28593
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: openfoam: Clean up to reduce closure.
>
>
>
>
> Date: 
>
> Mon, 25 Sep 2017 11:44:59 +0100
>
>
>
>
> This saves ~1GB.
>
> * gnu/packages/simulation.scm (openfoam)[outputs]: Add debug.
> [arguments]: Clean up .o and src after build.
> ---
>  gnu/packages/simulation.scm | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> diff --git a/gnu/packages/simulation.scm b/gnu/packages/simulation.scm
> index de07b6844..fef80a1ac 100644
> --- a/gnu/packages/simulation.scm
> +++ b/gnu/packages/simulation.scm
> @@ -84,6 +84,10 @@
>       `(("gzip" ,gzip)
>         ("gnuplot" ,gnuplot)
>         ("openmpi" ,openmpi)))
> +    ;; FIXME: Also separate tutorials (80MB) and src (60MB); maybe also doc
> +    ;; (8MB)
> +    (outputs '("debug"                  ;~60MB
> +               "out"))
>      (arguments
>       `( ;; Executable files and shared libraries are located in the 'platforms'
>         ;; subdirectory.
> @@ -171,6 +175,15 @@
>                          (("lockDir=.*$")
>                           "lockDir=$HOME/.$WM_PROJECT/.wmake\n"))
>                        #t))
> +                  (add-after 'build 'cleanup
> +                    ;; Avoid lots of junk installed
> +                    (lambda _
> +                      (delete-file-recursively
> +                       "platforms/linux64GccDPInt32Opt/src")
> +                      (delete-file-recursively
> +                       "platforms/linux64GccDPInt32OptSYSTEMOPENMPI/src")
> +                      (zero?
> +                       (system* "find" "-name" "*.o" "-delete"))))
>                    (replace 'install
>                      (lambda _
>                        ;; use 'OpenFOAM-version' convention
> -- 
> 2.11.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#28593] [PATCH] gnu: openfoam: Clean up to reduce closure.
>
>
>
>
> Date: 
>
> Fri, 01 Dec 2017 11:27:57 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)
>
>
>
>
> Dave Love <address@hidden> skribis:
>
> >>From dc88db3e91c70da5e6e557ed5fdd528499cb1c65 Mon Sep 17 00:00:00 2001
> > From: Dave Love <address@hidden>
> > Date: Sat, 21 Oct 2017 17:20:42 +0100
> > Subject: [PATCH] gnu: openfoam: Clean up to reduce closure.
> >
> > This saves ~1GB.
> >
> > * gnu/packages/simulation.scm (openfoam)[outputs]: Add debug.
> > [arguments]: Clean up .o and src after build.
>
> I removed the FIXME as suggested by Paul, made the changes below, and
> committed.
>
> Thank you,
> Ludo’.
>
> diff --git a/gnu/packages/simulation.scm b/gnu/packages/simulation.scm
> index 3e65d1687..a5b661e34 100644
> --- a/gnu/packages/simulation.scm
> +++ b/gnu/packages/simulation.scm
> @@ -84,8 +84,6 @@
>       `(("gzip" ,gzip)
>         ("gnuplot" ,gnuplot)
>         ("openmpi" ,openmpi)))
> -    ;; FIXME: Also separate tutorials (80MB) and src (60MB); maybe also doc
> -    ;; (8MB)
>      (outputs '("debug"                  ;~60MB
>                 "out"))
>      (arguments
> @@ -176,14 +174,14 @@
>                           "lockDir=$HOME/.$WM_PROJECT/.wmake\n"))
>                        #t))
>                    (add-after 'build 'cleanup
> -                    ;; Avoid unncessary, voluminous object and dep files
> +                    ;; Avoid unncessary, voluminous object and dep files.
>                      (lambda _
>                        (delete-file-recursively
>                         "platforms/linux64GccDPInt32Opt/src")
>                        (delete-file-recursively
>                         "platforms/linux64GccDPInt32OptSYSTEMOPENMPI")
> -                      (zero?
> -                       (system* "find" "-name" "*.o" "-delete"))))
> +                      (for-each delete-file (find-files "." "\\.o$"))
> +                      #t))
>                    (replace 'install
>                      (lambda _
>                        ;; use 'OpenFOAM-version' convention
>
> --- End Message ---